Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

2018-03-09 Thread Pavel Labath via lldb-commits
It seems my compiler is magic as well. Running the test against /usr/bin/clang also succeeds (all variants)... On Fri, 9 Mar 2018 at 10:19, Pavel Labath wrote: > > > > On Thu, 8 Mar 2018 at 18:46, Jim Ingham wrote: > >> >> >> > On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: >> > >> > >> > >>

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

2018-03-09 Thread Pavel Labath via lldb-commits
On Thu, 8 Mar 2018 at 18:46, Jim Ingham wrote: > > > > On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: > > > > > > > > > > On Thu, 8 Mar 2018 at 02:46, Davide Italiano > wrote: > > On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote: > > > The hashing algorithm gives different values - at least f

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

2018-03-08 Thread Vedant Kumar via lldb-commits
I've gone ahead and skipped this test for the dsym variant until this is resolved. r327089. vedant > On Mar 8, 2018, at 10:49 AM, Davide Italiano via lldb-commits > wrote: > > On Thu, Mar 8, 2018 at 10:46 AM, Jim Ingham wrote: >> >> >>> On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: >>>

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

2018-03-08 Thread Davide Italiano via lldb-commits
On Thu, Mar 8, 2018 at 10:46 AM, Jim Ingham wrote: > > >> On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: >> >> >> >> >> On Thu, 8 Mar 2018 at 02:46, Davide Italiano wrote: >> On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote: >> > The hashing algorithm gives different values - at least for foob

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

2018-03-08 Thread Jim Ingham via lldb-commits
> On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: > > > > > On Thu, 8 Mar 2018 at 02:46, Davide Italiano wrote: > On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote: > > The hashing algorithm gives different values - at least for foobár - > > between the two implementations. So if you buil

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

2018-03-08 Thread Pavel Labath via lldb-commits
On Thu, 8 Mar 2018 at 02:46, Davide Italiano wrote: > On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote: > > The hashing algorithm gives different values - at least for foobár - > between the two implementations. So if you build with an older clang, and > test with a new lldb, the type lookup fa

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

2018-03-07 Thread Davide Italiano via lldb-commits
On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote: > The hashing algorithm gives different values - at least for foobár - between > the two implementations. So if you build with an older clang, and test with > a new lldb, the type lookup fails. > This is not my case, I think? I'm building from

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

2018-03-07 Thread Jim Ingham via lldb-commits
The hashing algorithm gives different values - at least for foobár - between the two implementations. So if you build with an older clang, and test with a new lldb, the type lookup fails. Were the two algorithms supposed to be identical? It will mean that type lookups in the output of older c

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

2018-03-07 Thread Davide Italiano via lldb-commits
On Fri, Feb 23, 2018 at 9:49 AM, Pavel Labath via lldb-commits wrote: > Author: labath > Date: Fri Feb 23 09:49:26 2018 > New Revision: 325927 > > URL: http://llvm.org/viewvc/llvm-project?rev=325927&view=rev > Log: > Replace HashStringUsingDJB with llvm::djbHash > > Summary: > The llvm function is

[Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

2018-02-23 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 23 09:49:26 2018 New Revision: 325927 URL: http://llvm.org/viewvc/llvm-project?rev=325927&view=rev Log: Replace HashStringUsingDJB with llvm::djbHash Summary: The llvm function is equivalent to this one. Where possible I tried to replace const char* with llvm::StringR