Re: [Lldb-commits] [lldb] r323803 - Compile the LLDB tests out-of-tree.

2018-02-28 Thread Adrian Prantl via lldb-commits
Thanks! > On Feb 28, 2018, at 7:06 PM, Vedant Kumar wrote: > > Done, r326414 > >> On Feb 28, 2018, at 6:48 PM, Vedant Kumar > > wrote: >> >> Will test and commit momentarily, thanks! >> >> vedant >> >>> On Feb 28, 2018, at 6:47 PM, Adrian Prantl >>

Re: [Lldb-commits] [lldb] r323803 - Compile the LLDB tests out-of-tree.

2018-02-28 Thread Vedant Kumar via lldb-commits
Done, r326414 > On Feb 28, 2018, at 6:48 PM, Vedant Kumar wrote: > > Will test and commit momentarily, thanks! > > vedant > >> On Feb 28, 2018, at 6:47 PM, Adrian Prantl > > wrote: >> >> That looks reasonable, since this is a class method, yes. Thanks for >> spottin

Re: [Lldb-commits] [lldb] r323803 - Compile the LLDB tests out-of-tree.

2018-02-28 Thread Vedant Kumar via lldb-commits
Will test and commit momentarily, thanks! vedant > On Feb 28, 2018, at 6:47 PM, Adrian Prantl wrote: > > That looks reasonable, since this is a class method, yes. Thanks for spotting > it! Would you mind committing the change? > > -- adrian > >> On Feb 28, 2018, at 6:46 PM, Vedant Kumar >

Re: [Lldb-commits] [lldb] r323803 - Compile the LLDB tests out-of-tree.

2018-02-28 Thread Adrian Prantl via lldb-commits
That looks reasonable, since this is a class method, yes. Thanks for spotting it! Would you mind committing the change? -- adrian > On Feb 28, 2018, at 6:46 PM, Vedant Kumar wrote: > > Hey Adrian, > > Did you mean to write cls.getBuildArtifact() here? > > I'm seeing a Python exception locall

Re: [Lldb-commits] [lldb] r323803 - Compile the LLDB tests out-of-tree.

2018-02-28 Thread Vedant Kumar via lldb-commits
Hey Adrian, Did you mean to write cls.getBuildArtifact() here? I'm seeing a Python exception locally when I run check-lldb-single: Traceback (most recent call last): File "/Users/vsk/src/llvm.org-lldbsan/llvm/tools/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 584, in tearDownClass