Re: [Lldb-commits] [lldb] r319598 - Don't use llvm::EnablePrettyStackTrace on macOS.

2017-12-04 Thread Jim Ingham via lldb-commits
> On Dec 2, 2017, at 3:36 PM, Zachary Turner wrote: > > That said, it does seem to make more sense as something you would do in the > main lldb executable, and not in library code. > Yes, if we want to support it we need to make an SB API to turn it on. You can't turn it on in the driver by

Re: [Lldb-commits] [lldb] r319598 - Don't use llvm::EnablePrettyStackTrace on macOS.

2017-12-02 Thread Zachary Turner via lldb-commits
That said, it does seem to make more sense as something you would do in the main lldb executable, and not in library code. On Sat, Dec 2, 2017 at 12:26 PM Zachary Turner wrote: > I'm curious why it's not working as it's supposed to work on these > platforms. When it does work, it's quite helpfu

Re: [Lldb-commits] [lldb] r319598 - Don't use llvm::EnablePrettyStackTrace on macOS.

2017-12-02 Thread Zachary Turner via lldb-commits
I'm curious why it's not working as it's supposed to work on these platforms. When it does work, it's quite helpful On Sat, Dec 2, 2017 at 12:24 PM Davide Italiano wrote: > Maybe we should remove this feature altogether? > > On Fri, Dec 1, 2017 at 4:11 PM, Jim Ingham via lldb-commits > wrote:

Re: [Lldb-commits] [lldb] r319598 - Don't use llvm::EnablePrettyStackTrace on macOS.

2017-12-02 Thread Davide Italiano via lldb-commits
Maybe we should remove this feature altogether? On Fri, Dec 1, 2017 at 4:11 PM, Jim Ingham via lldb-commits wrote: > Author: jingham > Date: Fri Dec 1 16:11:18 2017 > New Revision: 319598 > > URL: http://llvm.org/viewvc/llvm-project?rev=319598&view=rev > Log: > Don't use llvm::EnablePrettyStackT

[Lldb-commits] [lldb] r319598 - Don't use llvm::EnablePrettyStackTrace on macOS.

2017-12-01 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Dec 1 16:11:18 2017 New Revision: 319598 URL: http://llvm.org/viewvc/llvm-project?rev=319598&view=rev Log: Don't use llvm::EnablePrettyStackTrace on macOS. LLDB.framework gets loaded into Xcode and other frameworks, and this is inserting a signal handler into the proce