Hi Zachary!
Thank you for your prompt attention!
I notice you added DumpHexBytes() back, but Dump() is still missing. Was Dump()
slated for a later patch?
-Tim
> On 3 Mar 2017, at 15:48, Zachary Turner wrote:
>
> Yea, it was a static method of DataExtractor before. I noticed the same
> thi
Sure, Zachary. I try to step in when I can.
Now that you mention it, your r296910 (DumpDataExtractor) patch is breaking
building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the removal of
Dump/DumpHexBytes from DataExtractor. I've coordinated with the Apple LLDB team
on how they want to foll
Might also be useful to have a list of "files only compiled on platform X"
somewhere. Then in this sort of case, you could compile, then scrutinize
carefully all the files in the "not my platform list."
Jim
> On Mar 3, 2017, at 4:51 PM, Jim Ingham via lldb-commits
> wrote:
>
> Yeah, you c
Yeah, you could have grepped (is that how you spell that?) for "#include
"lldb/Core/DataExtractor.h" then looked at any Dump method in the files that
turned up. That would have reduced the noise.
Ah, staircase wit...
Jim
> On Mar 3, 2017, at 4:46 PM, Zachary Turner wrote:
>
> I usually do t
I usually do this, like when I'm changing #includes I do grep / replace.
In this case it was a little tricky because a name liked Dump is so common
that if my code doesn't compile it, I might not catch it. (Granted, I
should have caught DumpHexBytes, not sure how I missed that one).
On Fri, Mar 3
I'll get this working, but in the future when you are making changes of this
sort please chase down all the instances of functions you are changing, even in
files you aren't building locally. There might be a use that your conversion
doesn't handle, and you don't want to find that out after you'
Is that still failing? Extractor.dump(...) should be replaced by
DumpDataExtractor(Extractor, ...) and then everything will work
On Fri, Mar 3, 2017 at 4:29 PM Tim Hammerquist
wrote:
> Hi Zachary!
>
> Thank you for your prompt attention!
>
> I notice you added DumpHexBytes() back, but Dump() is
I guess you could fudge by changing DumpDataExtractor.h to DataDumper.h to
indicate that it is more general than just data extractors.
Jim
> On Mar 3, 2017, at 3:48 PM, Zachary Turner wrote:
>
> Yea, it was a static method of DataExtractor before. I noticed the same
> thing when i saw it was
Yea, it was a static method of DataExtractor before. I noticed the same
thing when i saw it wasn't using any methods of DataExtractor. Oops!
Anyway since this is no less weird than before I'll leave it this way for
now until we figure out something better.
On Fri, Mar 3, 2017 at 3:46 PM Jim Ingh
Yeah, looks like you need to keep DumpHexBytes in DumpDataExtractor. That's a
little weird because it doesn't actually take a DataExtractor, but...
Jim
> On Mar 3, 2017, at 3:45 PM, Zachary Turner via lldb-commits
> wrote:
>
> I can fix that, I didn't see it in my tests because it doesn't co
I can fix that, I didn't see it in my tests because it doesn't compile that
file on Windows. I'll get a fix in shortly.
On Fri, Mar 3, 2017 at 3:38 PM Tim Hammerquist
wrote:
> Sure, Zachary. I try to step in when I can.
>
> Now that you mention it, your r296910 (DumpDataExtractor) patch is
> br
Thanks Tim!
I have a few more file moves coming up as well, sorry for the trouble!
On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: penryu
> Date: Fri Mar 3 17:17:29 2017
> New Revision: 296925
>
> URL: http://llvm.org/viewvc/llvm-p
Author: penryu
Date: Fri Mar 3 17:17:29 2017
New Revision: 296925
URL: http://llvm.org/viewvc/llvm-project?rev=296925&view=rev
Log:
Fix Darwin failures introduced in r296909
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://
13 matches
Mail list logo
