Re: [Lldb-commits] [lldb] r294019 - Push down more common code into PlatformPOSIX

2017-04-10 Thread Geoff Berry via lldb-commits
Hans, Sorry for the confusion, but this isn't the change I was referring to. I included the phabricator review numbers in my original message, not svn commit numbers. On 2/3/2017 4:54 PM, Hans Wennborg wrote: Geoff asked for this to be merged to 4.0. It looks like a nice change, but I'm a

Re: [Lldb-commits] [lldb] r294019 - Push down more common code into PlatformPOSIX

2017-02-03 Thread Hans Wennborg via lldb-commits
Sorry for the noise, I must have gotten the numbers wrong somehow. On Fri, Feb 3, 2017 at 1:59 PM, Geoff Berry wrote: > Hans, > > Sorry for the confusion, but this isn't the change I was referring to. I > included the phabricator review numbers in my original message, not svn > commit numbers. >

Re: [Lldb-commits] [lldb] r294019 - Push down more common code into PlatformPOSIX

2017-02-03 Thread Pavel Labath via lldb-commits
Yes, this is a cleanup commit. I don't see a reason for cherry-picking it. Geoff, why do you need this cherry-picked? cheers, pl On 3 February 2017 at 13:54, Hans Wennborg wrote: > Geoff asked for this to be merged to 4.0. It looks like a nice change, > but I'm a little hesitant since it doesn'

Re: [Lldb-commits] [lldb] r294019 - Push down more common code into PlatformPOSIX

2017-02-03 Thread Hans Wennborg via lldb-commits
Geoff asked for this to be merged to 4.0. It looks like a nice change, but I'm a little hesitant since it doesn't look like it's fixing a regression. Pavel, what do you think? On Fri, Feb 3, 2017 at 9:42 AM, Pavel Labath via lldb-commits wrote: > Author: labath > Date: Fri Feb 3 11:42:04 2017 >

[Lldb-commits] [lldb] r294019 - Push down more common code into PlatformPOSIX

2017-02-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 3 11:42:04 2017 New Revision: 294019 URL: http://llvm.org/viewvc/llvm-project?rev=294019&view=rev Log: Push down more common code into PlatformPOSIX Summary: - GetFileWithUUID: All platforms except PlatformDarwin had this. However, I see no reason why this code would