Re: [Lldb-commits] [lldb] r287597 - Add the new Args / entry-access API.

2016-11-22 Thread Omair Javaid via lldb-commits
Proposed change didnt fix the build errors so I have reverted changes from rev 287597 On 22 November 2016 at 14:18, Zachary Turner wrote: > Ack, I caught this and fixed it, but it looks like I didn't dcommit the fix. > I have no access until morning but if someone else does, you can either > reve

Re: [Lldb-commits] [lldb] r287597 - Add the new Args / entry-access API.

2016-11-22 Thread Zachary Turner via lldb-commits
Ack, I caught this and fixed it, but it looks like I didn't dcommit the fix. I have no access until morning but if someone else does, you can either revert or change return type to vector::const_iterator On Tue, Nov 22, 2016 at 12:45 AM Omair Javaid wrote: Linux buildbot also failing with simil

Re: [Lldb-commits] [lldb] r287597 - Add the new Args / entry-access API.

2016-11-22 Thread Omair Javaid via lldb-commits
Linux buildbot also failing with similar errors. On 22 November 2016 at 09:26, Ed Maste via lldb-commits wrote: > On 21 November 2016 at 18:18, Zachary Turner via lldb-commits > wrote: >> Author: zturner >> Date: Mon Nov 21 17:18:07 2016 >> New Revision: 287597 >> >> URL: http://llvm.org/viewvc/

Re: [Lldb-commits] [lldb] r287597 - Add the new Args / entry-access API.

2016-11-21 Thread Ed Maste via lldb-commits
On 21 November 2016 at 18:18, Zachary Turner via lldb-commits wrote: > Author: zturner > Date: Mon Nov 21 17:18:07 2016 > New Revision: 287597 > > URL: http://llvm.org/viewvc/llvm-project?rev=287597&view=rev > Log: > Add the new Args / entry-access API. FreeBSD buildbot is now failing with: http:

[Lldb-commits] [lldb] r287597 - Add the new Args / entry-access API.

2016-11-21 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Nov 21 17:18:07 2016 New Revision: 287597 URL: http://llvm.org/viewvc/llvm-project?rev=287597&view=rev Log: Add the new Args / entry-access API. The long-term goal here is to get rid of the functions GetArgumentAtIndex() and GetQuoteCharAtIndex(), instead replacing them