Re: [Lldb-commits] [lldb] r282171 - added environment variable-related Args gtests

2016-09-22 Thread Todd Fiala via lldb-commits
Okay. Yeah I don't see us needing to support the equal with trailing nothing. -Todd > On Sep 22, 2016, at 9:23 AM, Zachary Turner wrote: > > yea I mostly just wanted to know if we needed to specificlaly distinguish > between ARG=\0 and ARG\0. Because if so the second parameter would need to

Re: [Lldb-commits] [lldb] r282171 - added environment variable-related Args gtests

2016-09-22 Thread Todd Fiala via lldb-commits
Primarily because we pass them verbatim to posix_spawn and other launchers, and there it is legitimate to not have an equal with trailing nothingness. On the Xcode side, we use a ton of environment variables. As to whether there is a difference between ARG1=\0 and ARG1\0, I'm not sure. On Thu, Se

Re: [Lldb-commits] [lldb] r282171 - added environment variable-related Args gtests

2016-09-22 Thread Zachary Turner via lldb-commits
yea I mostly just wanted to know if we needed to specificlaly distinguish between ARG=\0 and ARG\0. Because if so the second parameter would need to be Optional since StringRef has no way to differentiate between "I don't refer to anything" versus "I refer to the empty string". (Technically it ki

Re: [Lldb-commits] [lldb] r282171 - added environment variable-related Args gtests

2016-09-22 Thread Zachary Turner via lldb-commits
Thanks for the test. Is there any practical difference between "ARGS=" and "ARGS"? On Thu, Sep 22, 2016 at 9:08 AM Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: tfiala > Date: Thu Sep 22 11:00:01 2016 > New Revision: 282171 > > URL: http://llvm.org/viewvc/llvm-proje

[Lldb-commits] [lldb] r282171 - added environment variable-related Args gtests

2016-09-22 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Sep 22 11:00:01 2016 New Revision: 282171 URL: http://llvm.org/viewvc/llvm-project?rev=282171&view=rev Log: added environment variable-related Args gtests Also fixed up a couple misbehaving functions. It is perfectly legal to have env vars with no values (i.e. the '=' an