Thanks for fixing it.
On Wed, Sep 21, 2016 at 4:20 PM, Ed Maste wrote:
> On 21 September 2016 at 21:38, Adrian McCarthy
> wrote:
> > That fix doesn't look complete:
>
> Thanks, I've applied your fix in r282119, and sorry for being hasty
> with the original change.
>
On 21 September 2016 at 21:38, Adrian McCarthy wrote:
> That fix doesn't look complete:
Thanks, I've applied your fix in r282119, and sorry for being hasty
with the original change.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
That fix doesn't look complete:
for (size_t i = 0; i < column - 1 && i < src_line.length(); ++i)
`column` is an unsigned integral type, so doing subtraction from it can
lead to surprising results. It's probably best to write it as:
for (size_t i = 0; i + 1 < column && i < src_line.length();
Author: emaste
Date: Wed Sep 21 16:14:31 2016
New Revision: 282112
URL: http://llvm.org/viewvc/llvm-project?rev=282112&view=rev
Log:
Fix integer sign warning from r282105
Modified:
lldb/trunk/source/Core/SourceManager.cpp
Modified: lldb/trunk/source/Core/SourceManager.cpp
URL:
http://llvm.o
