DavidSpickett wrote:
Everything passed on Windows
(https://lab.llvm.org/buildbot/#/builders/219/builds/7700) and the rest of the
lldb specific bots are green. You may get a few more messages as other builders
get to it (the Mac ones mainly), if it's a link error with
`lldbPluginProcessWindows
oltolm wrote:
Thank you David, I didn't see a button for merging the PR.
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
You'll have email from at least one Linux builder. I believe I've fixed that
link error with:
https://github.com/llvm/llvm-project/commit/513c2151cd0cddd90af91a6614b15b74b538963e
https://github.com/llvm/llvm-project/pull/74731
__
DavidSpickett wrote:
If you have permissions, once a PR is approved you can click "squash and merge"
to land it. I've gone ahead and done that for you in this time.
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-com
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
oltolm wrote:
What happens next with my PR?
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() {
return Status();
}
+
+const char *TargetThreadWindows::GetName() {
+ Log *log = GetLog(LLDBLog::Thread);
+ HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll");
+ if (hModule) {
+auto GetThreadDescription =
+
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() {
return Status();
}
+
+const char *TargetThreadWindows::GetName() {
+ Log *log = GetLog(LLDBLog::Thread);
+ HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll");
+ if (hModule) {
+auto GetThreadDescription =
--
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() {
return Status();
}
+
+const char *TargetThreadWindows::GetName() {
+ Log *log = GetLog(LLDBLog::Thread);
+ HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll");
+ if (hModule) {
+auto GetThreadDescription =
+
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() {
return Status();
}
+
+const char *TargetThreadWindows::GetName() {
+ Log *log = GetLog(LLDBLog::Thread);
+ HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll");
+ if (hModule) {
+auto GetThreadDescription =
+
https://github.com/oltolm updated
https://github.com/llvm/llvm-project/pull/74731
>From 9383b8b92849c71a96b4b4e7e55f615d8f2efedb Mon Sep 17 00:00:00 2001
From: oltolm
Date: Fri, 1 Dec 2023 16:49:13 +0100
Subject: [PATCH 1/3] lldb: add support for thread names on Windows
---
.../Windows/Common
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() {
return Status();
}
+
+const char *TargetThreadWindows::GetName() {
+ Log *log = GetLog(LLDBLog::Thread);
+ HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll");
+ if (hModule) {
+auto GetThreadDescription =
+
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() {
return Status();
}
+
+const char *TargetThreadWindows::GetName() {
+ Log *log = GetLog(LLDBLog::Thread);
+ HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll");
+ if (hModule) {
+auto GetThreadDescription =
--
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() {
return Status();
}
+
+const char *TargetThreadWindows::GetName() {
+ Log *log = GetLog(LLDBLog::Thread);
+ HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll");
+ if (hModule) {
+auto GetThreadDescription =
+
bulbazord wrote:
@compnerd Perhaps you can take a look at this one? Not sure who does Windows
work on LLDB these days.
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/clayborg commented:
One other way to test is to create a python test that makes a test windows
binary that creates a thread using the Windows APIs and then we set a
breakpoint in one of the thread functions and then verify the thread name is
returned in the output of "thread
oltolm wrote:
I have added a test.
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oltolm updated
https://github.com/llvm/llvm-project/pull/74731
>From 9383b8b92849c71a96b4b4e7e55f615d8f2efedb Mon Sep 17 00:00:00 2001
From: oltolm
Date: Fri, 1 Dec 2023 16:49:13 +0100
Subject: [PATCH 1/2] lldb: add support for thread names on Windows
---
.../Windows/Common
https://github.com/clayborg commented:
Sounds like there is good reason for linking in the kernel32.dll, so code looks
good to me. A windows only test that creates a thread with a known name would
be great to add where we verify the name is correct.
https://github.com/llvm/llvm-project/pull/74
https://github.com/Fulgen301 edited
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() {
return Status();
}
+
+const char *TargetThreadWindows::GetName() {
+ Log *log = GetLog(LLDBLog::Thread);
+ HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll");
+ if (hModule) {
+auto GetThreadDescription =
+
https://github.com/bulbazord commented:
The implementation looks fine to me. Can you write a test?
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() {
return Status();
}
+
+const char *TargetThreadWindows::GetName() {
+ Log *log = GetLog(LLDBLog::Thread);
+ HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll");
+ if (hModule) {
+auto GetThreadDescription =
+
@@ -33,6 +34,9 @@
using namespace lldb;
using namespace lldb_private;
+using GetThreadDescriptionFunctionPtr = HRESULT
+WINAPI (*)(HANDLE hThread, PWSTR *ppszThreadDescription);
+
clayborg wrote:
Can we just `#include ` and avoid manually declaring a
functio
https://github.com/oltolm updated
https://github.com/llvm/llvm-project/pull/74731
>From 9383b8b92849c71a96b4b4e7e55f615d8f2efedb Mon Sep 17 00:00:00 2001
From: oltolm
Date: Fri, 1 Dec 2023 16:49:13 +0100
Subject: [PATCH] lldb: add support for thread names on Windows
---
.../Windows/Common/Tar
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff dfd36aa70ec1cff0529272b00f6c6a81bf0cc49c
b9accfb579b6d2718ad12ee55dacf38257693d56 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: oltolm (oltolm)
Changes
This PR adds support for thread names in lldb on Windows.
```
(lldb) thr list
Process 2960 stopped
thread #53: tid = 0x03a0, 0x7ff84582db34
ntdll.dll`NtWaitForMultipleObjects + 20
thread #29: tid = 0x04ec, 0
https://github.com/oltolm created
https://github.com/llvm/llvm-project/pull/74731
This PR adds support for thread names in lldb on Windows.
```
(lldb) thr list
Process 2960 stopped
thread #53: tid = 0x03a0, 0x7ff84582db34
ntdll.dll`NtWaitForMultipleObjects + 20
thread #29: tid = 0x04ec
30 matches
Mail list logo
