Re: [Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

2019-12-11 Thread Jason Molenda via lldb-commits
On 12/11/19 02:09 AM, Pavel Labath wrote: > > On 11/12/2019 00:51, Jason Molenda via lldb-commits wrote: > > That was my first inclination -- I don't see how it can work correctly on a > > remote setup, just like TestMultilineCompletion.py which I added the same > > skip to -- but I know pe

Re: [Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

2019-12-11 Thread Pavel Labath via lldb-commits
On 11/12/2019 00:51, Jason Molenda via lldb-commits wrote: > That was my first inclination -- I don't see how it can work correctly on a > remote setup, just like TestMultilineCompletion.py which I added the same > skip to -- but I know people are doing remote linux testing for android and > thi

Re: [Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

2019-12-10 Thread Jason Molenda via lldb-commits
That was my first inclination -- I don't see how it can work correctly on a remote setup, just like TestMultilineCompletion.py which I added the same skip to -- but I know people are doing remote linux testing for android and this doesn't seem to have been a problem for them? I went the conserv

Re: [Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

2019-12-10 Thread Frédéric Riss via lldb-commits
I think it would be better to stick the equivalent of skipIfRemote in the Expect base class. > On Dec 10, 2019, at 3:15 PM, Jason Molenda via lldb-commits > wrote: > > > Author: Jason Molenda > Date: 2019-12-10T15:15:25-08:00 > New Revision: b0937be06e44c0cdc1c1aac16b76746150e70154 > > URL:

[Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

2019-12-10 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2019-12-10T15:15:25-08:00 New Revision: b0937be06e44c0cdc1c1aac16b76746150e70154 URL: https://github.com/llvm/llvm-project/commit/b0937be06e44c0cdc1c1aac16b76746150e70154 DIFF: https://github.com/llvm/llvm-project/commit/b0937be06e44c0cdc1c1aac16b76746150e70154.diff