@@ -1625,6 +1657,11 @@ void request_initialize(const llvm::json::Object
&request) {
"Get or set the repl behavior of lldb-dap evaluation requests.");
g_dap.progress_event_thread = std::thread(ProgressEventThreadFunction);
+ // singleStoppedEvent option is not from fo
@@ -255,45 +253,75 @@ void SendThreadStoppedEvent() {
lldb::tid_t first_tid_with_reason = LLDB_INVALID_THREAD_ID;
uint32_t num_threads_with_reason = 0;
bool focus_thread_exists = false;
+ lldb::SBThread focus_thread, first_thread_with_reason;
for (
clayborg wrote:
This feature hides what other threads are doing when you stop and any other
threads that stop for a reason can be hidden from the user. For example if we
have 5 threads stop at a breakpoint, but we only report 1 for thread 1, do we
see the right stop reason for the threads 2-5
@@ -0,0 +1,91 @@
+"""
+Test lldb-dap setBreakpoints request
+"""
+
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+import lldbdap_testcase
+from lldbsuite.test import lldbutil
+
+
+class TestDAP_stopEvents(lldbdap_testcase.DAPTestCaseBase):
+@s
jeffreytan81 wrote:
> If I have a program with lots of threads - particularly if they are running
> in a small set of work functions - it's very common to have multiple
> breakpoint hits at the same time. And in this mode I'm going to end up having
> to scroll down the list - which if I have l
jimingham wrote:
If I have a program with lots of threads - particularly if they are running in
a small set of work functions - it's very common to have multiple breakpoint
hits at the same time. And if there are lots of threads, then in this mode I'm
going to end up having to scroll down the
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/98568
>From 13af0ff31688ca0a23f1fec65ca2d5797b65e31f Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Thu, 11 Jul 2024 17:24:41 -0700
Subject: [PATCH 1/3] Support single stopped event in lldb-dap
---
.../test/t
jeffreytan81 wrote:
> What is going to happen in this mode if I have 5 threads stop at breakpoints,
> and each have a breakpoint command that prints "I hit breakpoint X on thread
> Y". I'll see that in the console for all the threads that hit breakpoints.
> But what will I see when I look at t
jimingham wrote:
What is going to happen in this mode if I have 5 threads stop at breakpoints,
and each have a breakpoint command that prints "I hit breakpoint X on thread
Y". I'll see that in the console for all the threads that hit breakpoints.
But what will I see when I look at the stop r
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/98568
>From 13af0ff31688ca0a23f1fec65ca2d5797b65e31f Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Thu, 11 Jul 2024 17:24:41 -0700
Subject: [PATCH 1/2] Support single stopped event in lldb-dap
---
.../test/t
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
b81fcd01bde51eb8976b81a2c0c19fc0645cd2ff...13af0ff31688ca0a23f1fec65ca2d5797b65e31f
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jeffreytan81)
Changes
Some targets have non-trivial amount of threads, when stopping, multiple
stopped events can be sent causing VSCode to show multiple yellow lines in code
editor which can be confusing to end users.
This PR intr
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/98568
Some targets have non-trivial amount of threads, when stopping, multiple
stopped events can be sent causing VSCode to show multiple yellow lines in code
editor which can be confusing to end users.
This PR
13 matches
Mail list logo
