[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

https://github.com/rastogishubham closed https://github.com/llvm/llvm-project/pull/83312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

https://github.com/rastogishubham updated https://github.com/llvm/llvm-project/pull/83312 >From cef723783edd5ba89fd5b9b0ec800fa1439ffb90 Mon Sep 17 00:00:00 2001 From: Shubham Sandeep Rastogi Date: Wed, 28 Feb 2024 10:28:55 -0800 Subject: [PATCH] Increase timeout to reduce test failure rate. T

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

@@ -6,6 +6,7 @@ class DAPTestCaseBase(TestBase): +timeoutval = 10 * (10 if ('ASAN_OPTIONS' in os.environ) else 1) walter-erquinigo wrote: Please add a comment here mentioning what the purpose of this variable is https://github.com/llvm/llvm-project/pull

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/83312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

https://github.com/walter-erquinigo approved this pull request. Other than a missing comment, this LGTM. Thanks! https://github.com/llvm/llvm-project/pull/83312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

https://github.com/rastogishubham updated https://github.com/llvm/llvm-project/pull/83312 >From 563ef808aa3b06e97b89e7b52d518705e97d9e14 Mon Sep 17 00:00:00 2001 From: Shubham Sandeep Rastogi Date: Wed, 28 Feb 2024 10:28:55 -0800 Subject: [PATCH] Increase timeout to reduce test failure rate. T

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/83312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

https://github.com/walter-erquinigo requested changes to this pull request. could you create instead a variable at the base test class level that can be used by other DAP tests when setting timeouts? I'm pretty sure at least one other test file uses timeouts. https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r c1b8c6cf41df4a148e7a89c3a3c7e8049b0a47af...53c507046527e04b7faa70ea17cd59b45e724f55 lldb/

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shubham Sandeep Rastogi (rastogishubham) Changes The timeout for this test was set to 1.0s which is very low, it should be a default of 10s and be increased by a factor of 10 if ASAN is enabled. This will help reduce the falkiness of the t

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

https://github.com/rastogishubham created https://github.com/llvm/llvm-project/pull/83312 The timeout for this test was set to 1.0s which is very low, it should be a default of 10s and be increased by a factor of 10 if ASAN is enabled. This will help reduce the falkiness of the test, especiall