[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

walter-erquinigo wrote: I thought you were meaning UI changes via the fblldb extension, but if you are modying your fork of VSCode, there's nothing to be done then. https://github.com/llvm/llvm-project/pull/90799 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/90799 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

jeffreytan81 wrote: > lgtm. It would be nice if new UI features could be added in the typescript > code of lldb-dap, so that all users benefit from them. @walter-erquinigo , do you mean upstream to VSCode? Yeah, we would like to upstream the changes if Microsoft is willing to take them. http

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

https://github.com/walter-erquinigo approved this pull request. lgtm. It would be nice if new UI features could be added in the typescript code of lldb-dap, so that all users benefit from them. https://github.com/llvm/llvm-project/pull/90799 ___ lldb-

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/90799 >From 2daf4aeaee1ce9062dfa964f3baeef0d7477479c Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Wed, 1 May 2024 16:35:18 -0700 Subject: [PATCH 1/4] Fix dap variable value format issue --- .../test/tools/l

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes While adding a UI feature in VSCode to toggle hex/dec in variables view window. I noticed that it does not work after second toggle. Then I noticed that there is a bug that we only explicitly set hex format not

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

https://github.com/jeffreytan81 ready_for_review https://github.com/llvm/llvm-project/pull/90799 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/90799 >From 2daf4aeaee1ce9062dfa964f3baeef0d7477479c Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Wed, 1 May 2024 16:35:18 -0700 Subject: [PATCH 1/3] Fix dap variable value format issue --- .../test/tools/l

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/90799 >From 2daf4aeaee1ce9062dfa964f3baeef0d7477479c Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Wed, 1 May 2024 16:35:18 -0700 Subject: [PATCH 1/2] Fix dap variable value format issue --- .../test/tools/l

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r cf3c714e4bd7b8a68793f2827080fe3388ae8bb1...2daf4aeaee1ce9062dfa964f3baeef0d7477479c lldb/

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cf3c714e4bd7b8a68793f2827080fe3388ae8bb1 2daf4aeaee1ce9062dfa964f3baeef0d7477479c --

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/90799 While adding a UI feature in VSCode to toggle hex/dec in variables view window. I noticed that it does not work after second toggle. Then I noticed that there is a bug that we only explicitly set hex format