https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/17] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/16] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/15] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/14] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/13] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/12] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/11] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
oontvoo wrote:
> This is definitely better than what you had before, but I still think it's
> more complicated than it needs to be. For one, I'd like to understand why is
> there a need for separate `TelemetryManager` and `TelemetryConfig` fields. If
> the downstream implementation is going to
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/10] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/9] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/8] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/7] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/5] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/labath commented:
This is definitely better than what you had before, but I still think it's more
complicated than it needs to be. For one, I'd like to understand why is there a
need for separate `TelemetryManager` and `TelemetryConfig` fields. If the
downstream implementati
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9387fd96314c59fc9aff1a82e478f9b89a97c20a
b767a2efb6f1d39e83523cfdf330ddd26a8cf892 --e
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/5] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/4] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/3] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/3] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/2] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
Details:
Upstream in LLDB, we will have a default TelemetryVendor plugin will provide a
default Config and NULL TelemetryManager. Downstream vendors can extend this to
provide a vendor-specific Config along wit
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/126588
Details:
Upstream in LLDB, we will have a default TelemetryVendor plugin will provide a
default Config and NULL TelemetryManager. Downstream vendors can extend this to
provide a vendor-specific Config along wi
37 matches
Mail list logo
