https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/27] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/27] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
oontvoo wrote:
Thanks, all. Just to wrap up, the only change required here is to remove the
PluginInterface inheritance (and renaming the current
`Manager::getPluginName()` to `Manager::getInstanceName()` to avoid confusion.
https://github.com/llvm/llvm-project/pull/126588
__
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/26] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
labath wrote:
> Given that they also need to support (1) they'd always have to be full blown
> plugins, right? So it's not like they could be migrated over to a "plugin
> light" if we came up with something like that?
Sort of. There would have to be *a* full-blown plugin. But there's no reason
oontvoo wrote:
> > The (baroque) way that the other plugins work serves two purposes:
> >
> > 1. controlling the type (class) of the plugin being created based on some
> > runtime property
> > 2. creating an arbitrary number of plugin instances
> >
> > For telemetry "plugins", I don't think we
JDevlieghere wrote:
> The (baroque) way that the other plugins work serves two purposes:
>
> 1. controlling the type (class) of the plugin being created based on some
> runtime property
> 2. creating an arbitrary number of plugin instances
>
> For telemetry "plugins", I don't think we want/nee
labath wrote:
> This was what we were doing in the [initial
> PR](https://github.com/llvm/llvm-project/pull/98528/files#diff-20a2060f8e87c6742d6f2c7ae97e919f8485995d7808bd9fccbfbede697a9ec7)
> but Pavel had correctly pointed out that the architecture was unnecessarily
> "baroque". GIven there
JDevlieghere wrote:
> This was what we were doing in the [initial
> PR](https://github.com/llvm/llvm-project/pull/98528/files#diff-20a2060f8e87c6742d6f2c7ae97e919f8485995d7808bd9fccbfbede697a9ec7)
> but Pavel had correctly pointed out that the architecture was unnecessarily
> "baroque". GIven
oontvoo wrote:
> Based on the title of this PR I was expecting something slightly different,
> so maybe I'm missing something. But if we want to make this an LLDB plugin
> (which I agree we should ), I would expect the `PluginManager` to manage the
> instance rather than the plugin doing itsel
JDevlieghere wrote:
Based on the title of this PR I was expecting something slightly different, so
maybe I'm missing something. But if we want to make this an LLDB plugin (which
I agree we should ), I would expect the `PluginManager` to manage the instance
rather than the plugin doing itself.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/25] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
@@ -0,0 +1,34 @@
+//===-- TestFakePlugin.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/24] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
@@ -0,0 +1,74 @@
+//===-- TelemetryTest.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/23] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
@@ -0,0 +1,34 @@
+//===-- TestFakePlugin.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,34 @@
+//===-- TestFakePlugin.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,74 @@
+//===-- TelemetryTest.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,74 @@
+//===-- TelemetryTest.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,74 @@
+//===-- TelemetryTest.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,74 @@
+//===-- TelemetryTest.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,74 @@
+//===-- TelemetryTest.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/labath commented:
Okay, I think we're ready to summon @JDevlieghere now. :)
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -59,11 +60,21 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
/// The base Telemetry manager instance in LLDB
/// This class declares additional instrumentation points
/// applicable to LLDB.
-class TelemetryManager : public llvm::telemetry::Manage
@@ -0,0 +1,13 @@
+if (LLVM_BUILD_TELEMETRY)
+ add_lldb_library(lldbPluginTelemetryFakePlugin PLUGIN
+ FakePlugin.cpp
+
+ LINK_LIBS
+lldbCore
+lldbUtility
+lldbPluginProcessUtility
+ LINK_COMPONENTS
+Support
+Telemetry
+
@@ -79,3 +79,7 @@ add_subdirectory(ValueObject)
if(LLDB_CAN_USE_DEBUGSERVER AND LLDB_TOOL_DEBUGSERVER_BUILD AND NOT
LLDB_USE_SYSTEM_DEBUGSERVER)
add_subdirectory(debugserver)
endif()
+
+if(LLVM_BUILD_TELEMETRY)
+ add_subdirectory(telemetry)
+endif()
oontvoo
@@ -0,0 +1,13 @@
+if (LLVM_BUILD_TELEMETRY)
+ add_lldb_library(lldbPluginTelemetryFakePlugin PLUGIN
+ FakePlugin.cpp
+
+ LINK_LIBS
+lldbCore
+lldbUtility
+lldbPluginProcessUtility
+ LINK_COMPONENTS
+Support
+Telemetry
+
@@ -79,3 +79,7 @@ add_subdirectory(ValueObject)
if(LLDB_CAN_USE_DEBUGSERVER AND LLDB_TOOL_DEBUGSERVER_BUILD AND NOT
LLDB_USE_SYSTEM_DEBUGSERVER)
add_subdirectory(debugserver)
endif()
+
+if(LLVM_BUILD_TELEMETRY)
+ add_subdirectory(telemetry)
+endif()
labath
@@ -59,11 +60,21 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
/// The base Telemetry manager instance in LLDB
/// This class declares additional instrumentation points
/// applicable to LLDB.
-class TelemetryManager : public llvm::telemetry::Manage
https://github.com/labath commented:
I like this. Now it's so simple that a test might not have even been necessary,
but since you've already started it, let's keep it, and we can later extend it
to test sending of telemetry events.
https://github.com/llvm/llvm-project/pull/126588
@@ -0,0 +1,45 @@
+//===-- FakePlugin.cpp --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,34 @@
+//===-- TestFakePlugin.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -79,3 +79,7 @@ add_subdirectory(ValueObject)
if(LLDB_CAN_USE_DEBUGSERVER AND LLDB_TOOL_DEBUGSERVER_BUILD AND NOT
LLDB_USE_SYSTEM_DEBUGSERVER)
add_subdirectory(debugserver)
endif()
+
+if(LLVM_BUILD_TELEMETRY)
+ add_subdirectory(telemetry)
+endif()
labath
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,45 @@
+//===-- FakePlugin.cpp --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -59,11 +60,21 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
/// The base Telemetry manager instance in LLDB
/// This class declares additional instrumentation points
/// applicable to LLDB.
-class TelemetryManager : public llvm::telemetry::Manage
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/17] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
42 matches
Mail list logo
