[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

medismailben wrote: Awesome! 🚢 it! https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/96001 >From a59949cc908d5216950f2530fe1455da8ad39b5f Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 13 Jun 2024 16:02:07 -0700 Subject: [PATCH] add unit test for breakpoint::setcallback --- lldb/in

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/medismailben approved this pull request. LGTM with comment https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,89 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/96001 >From 44ea5e0d0a319fa12463129ff072bcaef6112544 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 13 Jun 2024 16:02:07 -0700 Subject: [PATCH] add unit test for breakpoint::setcallback --- lldb/in

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,89 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,89 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,89 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/medismailben requested changes to this pull request. https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,89 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/96001 >From 86dcffcc7a1820756fe8104d8239f25185a27733 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 13 Jun 2024 16:02:07 -0700 Subject: [PATCH] add unit test for breakpoint::setcallback --- lldb/in

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,93 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/medismailben approved this pull request. LGTM, with comments addressed. https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,93 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -99,10 +99,15 @@ typedef std::optional (*SymbolLocatorLocateExecutableSymbolFile)( typedef bool (*SymbolLocatorDownloadObjectAndSymbolFile)( ModuleSpec &module_spec, Status &error, bool force_lookup, bool copy_executable); -typedef bool (*BreakpointHitCallback)(void

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -99,10 +99,15 @@ typedef std::optional (*SymbolLocatorLocateExecutableSymbolFile)( typedef bool (*SymbolLocatorDownloadObjectAndSymbolFile)( ModuleSpec &module_spec, Status &error, bool force_lookup, bool copy_executable); -typedef bool (*BreakpointHitCallback)(void

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/96001 >From 2cfcef620125ed7d0ba84acfa20de3064437282c Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 13 Jun 2024 16:02:07 -0700 Subject: [PATCH] add unit test for breakpoint::setcallback --- lldb/in

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/96001 >From aa575bbc2b91837851631cf7a14e03398e2efa48 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 13 Jun 2024 16:02:07 -0700 Subject: [PATCH] add unit test for breakpoint::setcallback --- lldb/in

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,89 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,89 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,89 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,89 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

chelcassanova wrote: Not anymore, I'll remove these. https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,89 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,89 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

@@ -0,0 +1,89 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

medismailben wrote: Do you still need this ? https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/medismailben requested changes to this pull request. This is a good start but still requires some work. https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/96001 >From 0dc804076d624883e966b58c94cae8dc5065f1e3 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 13 Jun 2024 16:02:07 -0700 Subject: [PATCH] add unit test for breakpoint::setcallback --- lldb/un

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes This commit adds a unit test for SBBreakpoint::SetCallback as it wasn't being tested before. --- Full diff: https://github.com/llvm/llvm-project/pull/96001.diff 2 Files Affected: - (modified) ll

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/96001 This commit adds a unit test for SBBreakpoint::SetCallback as it wasn't being tested before. >From dc51494a84d6b0dac1d4c6b106eeb6e625a09b58 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 13 J