Re: [Lldb-commits] [lldb] 92e1ebe - [trace] Fix destructor declaration

2020-10-03 Thread Walter Erquinigo via lldb-commits
But what about the case Vedant mentioned? >Otherwise, when a std::shared_ptr is destroyed, the destructor for > the derived TraceIntelPT instance won't run. Or is C++ smart enough to pick the destructor from TraceIntelPT class in this case? On 9/30/20, 5:56 AM, "Pavel Labath" wrote:

Re: [Lldb-commits] [lldb] 92e1ebe - [trace] Fix destructor declaration

2020-10-01 Thread Pavel Labath via lldb-commits
On 30/09/2020 20:25, Walter Erquinigo wrote: > But what about the case Vedant mentioned? > >>Otherwise, when a std::shared_ptr is destroyed, the destructor for >> the derived TraceIntelPT instance won't run. > > Or is C++ smart enough to pick the destructor from TraceIntelPT class in this >

Re: [Lldb-commits] [lldb] 92e1ebe - [trace] Fix destructor declaration

2020-09-30 Thread Pavel Labath via lldb-commits
On 29/09/2020 22:09, Walter Erquinigo via lldb-commits wrote: > The destructor must be defined in the implementation class so that it > can be called That doesn't sound right. Each class automatically gets a destructor if it does not declare one itself. "~Foo() override = default" is completely eq

[Lldb-commits] [lldb] 92e1ebe - [trace] Fix destructor declaration

2020-09-29 Thread Walter Erquinigo via lldb-commits
Author: Walter Erquinigo Date: 2020-09-29T13:09:52-07:00 New Revision: 92e1ebeaa1fe0e5461327d071c55167733834e60 URL: https://github.com/llvm/llvm-project/commit/92e1ebeaa1fe0e5461327d071c55167733834e60 DIFF: https://github.com/llvm/llvm-project/commit/92e1ebeaa1fe0e5461327d071c55167733834e60.di