https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/137113
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -217,3 +216,30 @@ def test_functionNameWithArgs(self):
self.continue_to_next_stop()
frame = self.get_stackFrames()[0]
self.assertEqual(frame["name"], "recurse(x=1)")
+
+@skipIfWindows
da-viper wrote:
LGTM
But I could not see why
@@ -102,3 +103,23 @@ def test_stackTrace(self):
self.assertGreaterEqual(
totalFrames, i, "total frames should include a pagination
offset"
)
+
+@skipIfWindows
da-viper wrote:
should skip linux
https://github.com/ll
https://github.com/da-viper approved this pull request.
https://github.com/llvm/llvm-project/pull/137113
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper edited
https://github.com/llvm/llvm-project/pull/137113
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/137113
>From 21681616560eceb9b46ef4c370817099fe149701 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 23 Apr 2025 20:05:19 -0700
Subject: [PATCH 1/4] [lldb-dap] Support StackFrameFormat
The debug adap
@@ -180,44 +184,53 @@ void StackTraceRequestHandler::operator()(
llvm::json::Object body;
lldb::SBFormat frame_format = dap.frame_format;
+ bool include_all = false;
ashgti wrote:
Should this default to `dap.configuration.displayExtendedBacktrace` and th
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/137113
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/137113
>From 21681616560eceb9b46ef4c370817099fe149701 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 23 Apr 2025 20:05:19 -0700
Subject: [PATCH 1/3] [lldb-dap] Support StackFrameFormat
The debug adap
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
lldb/packa
@@ -178,14 +179,45 @@ void StackTraceRequestHandler::operator()(
llvm::json::Array stack_frames;
llvm::json::Object body;
+ lldb::SBFormat frame_format = dap.frame_format;
+
+ if (const auto *format = arguments->getObject("format")) {
+const bool parameters = GetBool
@@ -178,14 +179,45 @@ void StackTraceRequestHandler::operator()(
llvm::json::Array stack_frames;
llvm::json::Object body;
+ lldb::SBFormat frame_format = dap.frame_format;
+
+ if (const auto *format = arguments->getObject("format")) {
+const bool parameters = GetBool
@@ -178,14 +179,45 @@ void StackTraceRequestHandler::operator()(
llvm::json::Array stack_frames;
llvm::json::Object body;
+ lldb::SBFormat frame_format = dap.frame_format;
+
+ if (const auto *format = arguments->getObject("format")) {
ashgti wrote:
Anot
@@ -178,14 +179,45 @@ void StackTraceRequestHandler::operator()(
llvm::json::Array stack_frames;
llvm::json::Object body;
+ lldb::SBFormat frame_format = dap.frame_format;
+
+ if (const auto *format = arguments->getObject("format")) {
+const bool parameters = GetBool
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The debug adapter protocol supports an option to provide formatting information
for a stack frames as part of the StackTrace request. lldb-dap incorrectly
advertises it supports this, but until this
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/137113
The debug adapter protocol supports an option to provide formatting information
for a stack frames as part of the StackTrace request. lldb-dap incorrectly
advertises it supports this, but until this PR tha
16 matches
Mail list logo