https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
@@ -0,0 +1,35 @@
+//===-- DisconnectRequestHandlerTest.cpp
--===//
JDevlieghere wrote:
```suggestion
//===-- DisconnectTest.cpp ===//
```
https://github.com/llvm/llvm-project/pull/1
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
@@ -1,8 +1,11 @@
add_lldb_unittest(DAPTests
+ DAPTest.cpp
+ Handler/DisconnectRequestHandlerTest.cpp
ashgti wrote:
I renamed the file to `Handler/DisconnectTest.cpp` but should the test be
`DisconnectTest` or should it be `DisconnectRequestHandlerTest` since
@@ -0,0 +1,70 @@
+//===-- TestBase.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
https://github.com/JDevlieghere approved this pull request.
I like the test base classes.
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
@@ -1,8 +1,11 @@
add_lldb_unittest(DAPTests
+ DAPTest.cpp
+ Handler/DisconnectRequestHandlerTest.cpp
JDevlieghere wrote:
I somewhat regret the naming of the request handlers (*). Learning from our
mistakes, maybe here we should just call it `Handler/Disconne
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,70 @@
+//===-- TestBase.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
>From 6f947e38ad4f744754cf13c1094c4e5e3fd249b6 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 10:31:40 -0700
Subject: [PATCH 1/5] [lldb-dap] Setup DAP for unit testing.
This is a very simple
ashgti wrote:
I added a few extra tests here and some extra base classes to help setup tests.
LMKWYT
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
>From 6f947e38ad4f744754cf13c1094c4e5e3fd249b6 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 10:31:40 -0700
Subject: [PATCH 1/4] [lldb-dap] Setup DAP for unit testing.
This is a very simple
JDevlieghere wrote:
> Yea, thats my mistake. I made the protocol classes to match the names of the
> spec, but we don't really have to do that as long as the `toJSON`/`fromJSON`
> adjusts the names, they can be different.
I think we discussed this at some point in the past and I'm personally o
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
>From 6f947e38ad4f744754cf13c1094c4e5e3fd249b6 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 10:31:40 -0700
Subject: [PATCH 1/3] [lldb-dap] Setup DAP for unit testing.
This is a very simple
ashgti wrote:
Yea, thats my mistake. I made the protocol classes to match the names of the
spec, but we don't really have to do that as long as the `toJSON`/`fromJSON`
adjusts the names, they can be different.
https://github.com/llvm/llvm-project/pull/139937
___
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
>From 6f947e38ad4f744754cf13c1094c4e5e3fd249b6 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 10:31:40 -0700
Subject: [PATCH 1/2] [lldb-dap] Setup DAP for unit testing.
This is a very simple
ashgti wrote:
Should I rename `toDAP`/`fromDAP` to `to_dap`/`from_dap`? I think thats more
inline with how lldb names variables, right?
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
JDevlieghere wrote:
> Should I rename `toDAP`/`fromDAP` to `to_dap`/`from_dap`? I think thats more
> inline with how lldb names variables, right?
Yes, good point. Currently we have a weird mix of styles. Once everything has
been migrated to use the protocol classes, we should go through the co
https://github.com/JDevlieghere approved this pull request.
Very excited to see more unit testing!
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This is a very simple case that currently only validates we can create a DAP
instance and send a message over the transport layer. More in-depth tests will
require additional helpers and possibly refactors of
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/139937
This is a very simple case that currently only validates we can create a DAP
instance and send a message over the transport layer. More in-depth tests will
require additional helpers and possibly refactors of DA
23 matches
Mail list logo
