[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-08 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Attaching the bot output before it gets recycled: [stdio-3.txt](https://github.com/user-attachments/files/20111424/stdio-3.txt) https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-08 Thread David Spickett via lldb-commits
DavidSpickett wrote: We have a few failures on Windows on Arm too: https://github.com/llvm/llvm-project/commit/2668167e2cf935528f7d93cb3b12a651a29e52f6 I've skipped those tests for now. https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commit

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: All the Linux and Windows buildbots are green, but GreenDragon is consistently failing with one of the breakpoint tests and it's not immediately obvious what the problem is. If I rerun the tests enough times, I can reproduce a failure locally. I've disabled those tests in d

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I re-landed the launch sequence patch (aeeb9a3c09f40f42a1e8e5e3c8dbde3b260744bd) and the Windows bots are happy again. Given that was the only objections, I'm going to merge this so we can get some insights overnight. As I said in the description, I expect the tests to be

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: As far as I can know, https://github.com/llvm/llvm-project/pull/138219 went onto main, so you can revert my revert to get that back. Then there was https://github.com/llvm/llvm-project/commit/69a0af35a5860156836e9e295ecef9de3474db11, which was later reverted in https://g

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread Ebuka Ezike via lldb-commits
da-viper wrote: is there a branch tracking the reverted changes #138219, I have an old windows 10 pc i could use to reproduce it. https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett requested changes to this pull request. Actually the launch sequence changes are breaking Windows tests. I need to see that all green first. https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Sure, let's give this a go now. (rather than end of week for a potential weekend of red) https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/138791 Rate limit ยท GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
@@ -18,6 +18,7 @@ import socket +@skip("SBTarget::ConnectRemote is not synchronous") JDevlieghere wrote: I filed #138803 https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread John Harrison via lldb-commits
@@ -18,6 +18,7 @@ import socket +@skip("SBTarget::ConnectRemote is not synchronous") ashgti wrote: Should we put a link to the bug to fix this test? https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commit

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread via lldb-commits
https://github.com/kusmour approved this pull request. Let's go (fingercrossed https://github.com/llvm/llvm-project/pull/138791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Re-enable the lldb-dap tests. We've spent the last week improving the reliability of the test suite and the tests now pass reliably on macOS and Linux at desk. Let's see how things fare on the bots.

[Lldb-commits] [lldb] [lldb-dap] Re-enable the lldb-dap tests (PR #138791)

2025-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/138791 Re-enable the lldb-dap tests. We've spent the last week improving the reliability of the test suite and the tests now pass reliably on macOS and Linux at desk. Let's see how things fare on the bots.