[Lldb-commits] [lldb] [lldb-dap] Addressing ubsan enum usage. (PR #133542)

2025-03-29 Thread John Harrison via lldb-commits
ashgti wrote: Sure I’ll convert it to that in a follow up patch https://github.com/llvm/llvm-project/pull/133542 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Addressing ubsan enum usage. (PR #133542)

2025-03-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: I think using `FLAGS_ENUM` here is misleading: these are not flags which you can mask. Could we instead just add a type like `enum Message: unsinged` or `enum Message: uint64_t` to make UBSan happy? https://github.com/llvm/llvm-project/pull/133542 __

[Lldb-commits] [lldb] [lldb-dap] Addressing ubsan enum usage. (PR #133542)

2025-03-28 Thread Walter Lee via lldb-commits
https://github.com/googlewalt approved this pull request. https://github.com/llvm/llvm-project/pull/133542 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Addressing ubsan enum usage. (PR #133542)

2025-03-28 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/133542 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Addressing ubsan enum usage. (PR #133542)

2025-03-28 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/133542 >From 55aa8ef8cc65307948a1cf0803c5c7c240be0efa Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 28 Mar 2025 16:29:06 -0700 Subject: [PATCH 1/2] [lldb-dap] Addressing ubsan enum usage. Running tests with u

[Lldb-commits] [lldb] [lldb-dap] Addressing ubsan enum usage. (PR #133542)

2025-03-28 Thread Walter Lee via lldb-commits
https://github.com/googlewalt approved this pull request. https://github.com/llvm/llvm-project/pull/133542 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Addressing ubsan enum usage. (PR #133542)

2025-03-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Running tests with ubsan enabled showed that the current `protocol::AdapterFeature` and `protocol::ClientFeature` enums are incorrectly defined if we want to use them in a `llvm::DenseSet`. The enums are curr

[Lldb-commits] [lldb] [lldb-dap] Addressing ubsan enum usage. (PR #133542)

2025-03-28 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/133542 Running tests with ubsan enabled showed that the current `protocol::AdapterFeature` and `protocol::ClientFeature` enums are incorrectly defined if we want to use them in a `llvm::DenseSet`. The enums are current