[Lldb-commits] [lldb] [lldb] Support both Lua 5.3 and Lua 5.4 (PR #115500)

2024-11-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/115500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support both Lua 5.3 and Lua 5.4 (PR #115500)

2024-11-10 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/115500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support both Lua 5.3 and Lua 5.4 (PR #115500)

2024-11-08 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I'd say this was a Freudian slip. https://github.com/llvm/llvm-project/pull/115500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support both Lua 5.3 and Lua 5.4 (PR #115500)

2024-11-08 Thread via lldb-commits
jimingham wrote: Spell-checkers sometimes reveal hidden truths... Jim > On Nov 8, 2024, at 10:52 AM, Pavel Labath ***@***.***> wrote: > > > detest.py > > I'm not a fan of how TestLuaAPI.py works today. > > You could even say you detest it. :P > > — > Reply to this email directly, view it o

[Lldb-commits] [lldb] [lldb] Support both Lua 5.3 and Lua 5.4 (PR #115500)

2024-11-08 Thread Pavel Labath via lldb-commits
labath wrote: > `detest.py` > I'm not a fan of how TestLuaAPI.py works today. You could even say you detest it. :P https://github.com/llvm/llvm-project/pull/115500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb] Support both Lua 5.3 and Lua 5.4 (PR #115500)

2024-11-08 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I'm not a fan of how TestLuaAPI.py works today. I think it should be its own lit format, without going through `detest.py`. I think that shouldn't be too hard, but I'll do that as a follow-up. https://github.com/llvm/llvm-project/pull/115500 ___

[Lldb-commits] [lldb] [lldb] Support both Lua 5.3 and Lua 5.4 (PR #115500)

2024-11-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/115500 >From 4858c858724b3b1047dec4f3d7dd00e672dfdb41 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 8 Nov 2024 07:39:01 -0800 Subject: [PATCH 1/2] [lldb] Support both Lua 5.3 and Lua 5.4 Lua 5.3 and

[Lldb-commits] [lldb] [lldb] Support both Lua 5.3 and Lua 5.4 (PR #115500)

2024-11-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Lua 5.3 and Lua 5.4 are similar enough that we can easily support both in LLDB. This patch adds support for building LLDB with both and updates the documentation accordingly. --- Full diff: https:/

[Lldb-commits] [lldb] [lldb] Support both Lua 5.3 and Lua 5.4 (PR #115500)

2024-11-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/115500 Lua 5.3 and Lua 5.4 are similar enough that we can easily support both in LLDB. This patch adds support for building LLDB with both and updates the documentation accordingly. >From 4858c858724b3b1047dec4f