[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-14 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I added a configuration entry and corresponding decorator in #66447. https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-14 Thread Daniel Thornburgh via lldb-commits
mysterymath wrote: I dug into this a little bit; it looks like the autodetection for `LLDB_EDITLINE_USE_WCHAR` was broken on our build, so it was turned `OFF`, even though our libedit supports the wchar API. I can fix this on our end, but more generally, is there a way to condition this test o

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-14 Thread via lldb-commits
gulfemsavrun wrote: We started seeing a test failure after this commit. ``` UNRESOLVED: lldb-api :: terminal/TestEditline.py (2430 of 2430) TEST 'lldb-api :: terminal/TestEditline.py' FAILED Script: -- /b/s/w/ir/x/w/lldb_install/python3/bin/python3 /b/s

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Account for Unicode when computing the prompt column width. Previously, the string length (i.e. number of bytes) rather than the width of the Glyph was used to compute the cursor position. The result was that the cursor would be

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Related to #66218 https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/66312: Account for Unicode when computing the prompt column width. Previously, the string length (i.e. number of bytes) rather than the width of the Glyph was used to compute the cursor position. The result was t

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits