https://github.com/ldm0 updated https://github.com/llvm/llvm-project/pull/111684
>From aefa120446a4c31fe9569d76ae3950c29d8d35e9 Mon Sep 17 00:00:00 2001
From: Liu Dingming
Date: Wed, 9 Oct 2024 21:57:24 +0800
Subject: [PATCH] [lldb] Simplify macOS thread name fetching (NFC)
Remove unnecessary `
@@ -265,6 +264,25 @@ bool MachThread::GetBasicInfo(thread_t thread,
return false;
}
+struct thread_extended_info *MachThread::GetExtendedInfo() {
+ if (MachThread::GetExtendedInfo(m_mach_port_number, &m_extended_info))
+return &m_extended_info;
+ return NULL;
+}
+
+boo
https://github.com/ldm0 updated https://github.com/llvm/llvm-project/pull/111684
>From 09a65dc9729938d5920174cac180164a8e3eb7a2 Mon Sep 17 00:00:00 2001
From: Liu Dingming
Date: Wed, 9 Oct 2024 21:57:24 +0800
Subject: [PATCH] [lldb] Simplify macOS thread name fetching.
Remove unnecessary `proc_
jimingham wrote:
I asked some folks who know and the proc_pidinfo call and the
extended_thread_info read the same data, so this should be NFC...
https://github.com/llvm/llvm-project/pull/111684
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -265,6 +264,25 @@ bool MachThread::GetBasicInfo(thread_t thread,
return false;
}
+struct thread_extended_info *MachThread::GetExtendedInfo() {
+ if (MachThread::GetExtendedInfo(m_mach_port_number, &m_extended_info))
+return &m_extended_info;
+ return NULL;
+}
+
+boo
https://github.com/JDevlieghere approved this pull request.
LGTM if this makes sense to @jasonmolenda
https://github.com/llvm/llvm-project/pull/111684
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -126,6 +127,8 @@ class MachThread {
protected:
static bool GetBasicInfo(thread_t threadID,
struct thread_basic_info *basic_info);
+ static bool GetExtendedInfo(thread_t threadID,
+ struct thread_extended_info *extend
https://github.com/ldm0 updated https://github.com/llvm/llvm-project/pull/111684
>From c700dd4b5bf5009b934d259becddab9fc10b9cb2 Mon Sep 17 00:00:00 2001
From: Liu Dingming
Date: Wed, 9 Oct 2024 21:57:24 +0800
Subject: [PATCH] [lldb] Simplify macOS thread name fetching.
Remove unnecessary `proc_
@@ -126,6 +127,8 @@ class MachThread {
protected:
static bool GetBasicInfo(thread_t threadID,
struct thread_basic_info *basic_info);
+ static bool GetExtendedInfo(thread_t threadID,
+ struct thread_extended_info *extend
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Donough Liu (ldm0)
Changes
Remove unnecessary `proc_pidinfo` calling.
---
Full diff: https://github.com/llvm/llvm-project/pull/111684.diff
2 Files Affected:
- (modified) lldb/tools/debugserver/source/MacOSX/MachThread.cpp (+25-22)
- (mo
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/ldm0 created https://github.com/llvm/llvm-project/pull/111684
Remove unnecessary `proc_pidinfo` calling.
>From e8432f711822d605b5136574967f7c7f133dfe73 Mon Sep 17 00:00:00 2001
From: Liu Dingming
Date: Wed, 9 Oct 2024 21:57:24 +0800
Subject: [PATCH] [lldb] Simplify macOS thre
12 matches
Mail list logo
