https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slackito approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,5 +1,5 @@
{
- "name": "lldb-vscode",
+ "name": "lldb-dap",
DavidSpickett wrote:
This and disassembly.json are still in the wrong place. I think move everything
up one level and delete the lldb-vscode folder. As the instructions refer to
packa
@@ -388,7 +385,7 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread, uint32_t stop_id);
/// The variable name of \a value or a default placeholder.
const char *GetNonNullVariableName(lldb::SBValue value);
-/// VSCode can't display two variables with the same
@@ -437,7 +434,7 @@ std::string
CreateUniqueVariableNameForDisplay(lldb::SBValue v,
/// context (e.g. locals). This can happen due to shadowed variables in
/// nested blocks.
///
-/// As VSCode doesn't render two of more variables with the same name, we
---
https://github.com/slackito commented:
Thanks for doing this!
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slackito edited
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -196,6 +196,9 @@ Changes to LLDB
for formatters to quickly find directly nested type when it's known
where to search for it, avoiding more expensive global search via
``SBTarget::FindFirstType``.
+* ``lldb-vscode`` was renamed to ``lldb-dap`` and and its installation
+
@@ -388,7 +385,7 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread, uint32_t stop_id);
/// The variable name of \a value or a default placeholder.
const char *GetNonNullVariableName(lldb::SBValue value);
-/// VSCode can't display two variables with the same
walter-erquinigo wrote:
fantastic!
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> @JDevlieghere , PTAL
> https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/16?u=wallace
I just replied! :D
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.
walter-erquinigo wrote:
@JDevlieghere , PTAL
https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/16?u=wallace
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
@@ -40,59 +41,59 @@ If you want to make a stand alone plug-in that you can send
to others on UNIX
systems:
```bash
-mkdir -p ~/llvm-org.lldb-vscode-0.1.0/bin
-cp package.json ~/llvm-org.lldb-vscode-0.1.0
-cd ~/llvm-org.lldb-vscode-0.1.0/bin
-cp /path/to/a/built/lldb-vscode .
@@ -18,9 +18,10 @@
# Introduction
JDevlieghere wrote:
I've made `lldb-vscode` a symlink to `lldb-dap`.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
JDevlieghere wrote:
> Actually there was a ninja target for `lldb-dap` but it wasn't built by
> default. Again, existing cmake config so if yours is fine then ignore this.
Yes, I had the same thing happen to me with an incremental build, but
everything looked correct for a clean build.
https
DavidSpickett wrote:
Actually there was a ninja target for `lldb-dap` but it wasn't built by
default. Again, existing cmake config so if yours is fine then ignore this.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb
DavidSpickett wrote:
I built this locally and I did not get a `bin/lldb-dap` only `lldb-vscde` as
before, but it was an existing build folder. So if your clean build is correct
you can ignore that part.
I followed the install instructions and got the "LLDB VSCode" extension with
type "llda-da
@@ -1,5 +1,5 @@
{
- "name": "lldb-vscode",
+ "name": "lldb-dap",
DavidSpickett wrote:
This and others are still in an "lldb-vscode" folder, that doesn't seem right.
https://github.com/llvm/llvm-project/pull/69264
DavidSpickett wrote:
Also I just gave you some conflicts with
https://github.com/llvm/llvm-project/commit/4606712ef5b422edbe3799b665dcad7dcf348b90.
I think only the "type" bit needs changing to "lldb-dap".
https://github.com/llvm/llvm-project/pull/69264
@@ -40,59 +41,59 @@ If you want to make a stand alone plug-in that you can send
to others on UNIX
systems:
```bash
-mkdir -p ~/llvm-org.lldb-vscode-0.1.0/bin
-cp package.json ~/llvm-org.lldb-vscode-0.1.0
-cd ~/llvm-org.lldb-vscode-0.1.0/bin
-cp /path/to/a/built/lldb-vscode .
@@ -196,6 +196,7 @@ Changes to LLDB
for formatters to quickly find directly nested type when it's known
where to search for it, avoiding more expensive global search via
``SBTarget::FindFirstType``.
+* ``lldb-vscode`` was renamed to `lldb-dap``.
DavidSpic
@@ -18,9 +18,10 @@
# Introduction
-The `lldb-vscode` tool creates a command line tool that implements the [Visual
-Studio Code Debug
API](https://code.visualstudio.com/docs/extensionAPI/api-debugging).
-It can be installed as an extension for the Visual Studio Code and Nucli
@@ -18,9 +18,10 @@
# Introduction
DavidSpickett wrote:
I think a stub README at the old lldb-vscode location is worth adding. It
should just link here.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b225934a4b0d2944958a53269665b00e7eae4875
92130a4fe2499a962e54d2628947ed1798ff8dc2 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Rename lldb-vscode to lldb-dap. This change is largely mechanical. The
following substitutions cover the majority of the changes in this commit:
s/VSCODE/DAP/
s/VSCode/DAP/
s/vscode/dap/
s/g
27 matches
Mail list logo
