https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/135455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/135455
>From b1416c5e13207eaa56985c84e9c2ac74db6a4d2b Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 11 Apr 2025 22:48:44 +
Subject: [PATCH 1/3] [lldb] Remove ProcessRunLock::TrySetRunning
I trac
labath wrote:
Thanks for looking into this.
https://github.com/llvm/llvm-project/pull/135455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/135455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -60,6 +49,7 @@ bool ProcessRunLock::SetStopped() {
::pthread_rwlock_unlock(&m_rwlock);
labath wrote:
This should also do the `was_running` dance.
https://github.com/llvm/llvm-project/pull/135455
___
lldb-commits
https://github.com/labath approved this pull request.
I was looking at this code as well, and I've (also) came to the conclusion that
`TrySetRunning` is a problem.
https://github.com/llvm/llvm-project/pull/135455
___
lldb-commits mailing list
lldb-com
@@ -29,8 +29,13 @@ class ProcessRunLock {
bool ReadTryLock();
bool ReadUnlock();
+
+ /// Set the process to running. Returns true if the process was stopped.
+ /// Return false if the process was running.
bool SetRunning();
- bool TrySetRunning();
+
+ /// Set the pr
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/135455
>From b1416c5e13207eaa56985c84e9c2ac74db6a4d2b Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 11 Apr 2025 22:48:44 +
Subject: [PATCH 1/2] [lldb] Remove ProcessRunLock::TrySetRunning
I trac
jimingham wrote:
This looks good to me, but we've discussed this already so I'm a prejudiced
judge. We should maybe wait on a second opinion...
https://github.com/llvm/llvm-project/pull/135455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -1325,9 +1323,9 @@ void Process::SetPublicState(StateType new_state, bool
restarted) {
Status Process::Resume() {
Log *log(GetLog(LLDBLog::State | LLDBLog::Process));
LLDB_LOGF(log, "(plugin = %s) -- locking run lock", GetPluginName().data());
- if (!m_public_run_lock.
@@ -29,8 +29,13 @@ class ProcessRunLock {
bool ReadTryLock();
bool ReadUnlock();
+
+ /// Set the process to running. Returns true if the process was stopped.
+ /// Return true if the process was running.
jimingham wrote:
One of those two `true`'s has to
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
I traced the issue reported by Caroline and Pavel in #134757 back to
the call to ProcessRunLock::TrySetRunning. When that fails, we get a somewhat
misleading error message:
> process resume at entr
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/135455
I traced the issue reported by Caroline and Pavel in #134757 back to the call
to ProcessRunLock::TrySetRunning. When that fails, we get a somewhat misleading
error message:
> process resume at entry point
13 matches
Mail list logo
