[Lldb-commits] [lldb] [lldb] Remove PATH workaround for Android (PR #124682)

2025-01-29 Thread Brad Smith via lldb-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/124682 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove PATH workaround for Android (PR #124682)

2025-01-29 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/124682 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove PATH workaround for Android (PR #124682)

2025-01-28 Thread Brad Smith via lldb-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/124682 >From fa2ef2fb98942b4d0f52c441f29fa48063b314b4 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Mon, 27 Jan 2025 22:16:53 -0500 Subject: [PATCH] [lldb] Remove PATH workaround for Android --- lldb/source/Host/posi

[Lldb-commits] [lldb] [lldb] Remove PATH workaround for Android (PR #124682)

2025-01-28 Thread Brad Smith via lldb-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/124682 >From 9046fce2f1ff2e4ff540e47c2daa70d1ea6df34e Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Mon, 27 Jan 2025 22:16:53 -0500 Subject: [PATCH] [lldb] Remove PATH workaround for Android --- lldb/source/Host/posi

[Lldb-commits] [lldb] [lldb] Remove PATH workaround for Android (PR #124682)

2025-01-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cc97653d534e80745a0cfb0143972e8d4dec9f74 60d2ba572b2f597f66e5876d3796d295bbb1aa27 --e

[Lldb-commits] [lldb] [lldb] Remove PATH workaround for Android (PR #124682)

2025-01-28 Thread via lldb-commits
enh-google wrote: > Let's delete the FixupEnvironment function as well (replace it with a direct > `env.getEnvp() call`) -- it only exists to hide the android hack. +1 --- seems weird to say "fix up" when doing nothing. otherwise lgtm... https://github.com/llvm/llvm-project/pull/124682 ___