ashgti wrote:
Okay, it sounds like I should remove the `-#` from dotest.py since its broken
and `-y` since its not used anywhere.
I can take a look at lit and see if there is some way to integrate re-running a
test there. I'll check if there is a way we could also integrate the failfast
flag
@@ -204,19 +204,19 @@ def create_parser():
action="append",
help='Run "setting set SETTING VALUE" before executing any test.',
)
-group.add_argument(
-"-y",
-type=int,
-metavar="count",
-help="Specify the iteration count u
labath wrote:
+1 for removing the option :)
https://github.com/llvm/llvm-project/pull/143797
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -665,17 +668,23 @@ def iter_filters():
filtered = True
print("adding filter spec %s to module %s" % (filterspec,
repr(module)))
tests = unittest.defaultTestLoader.loadTestsFromName(filterspec,
module)
-configuration.suite.addTests(tests)
+
@@ -21,6 +21,9 @@
# The test suite.
suite = unittest.TestSuite()
+# Stop at the first failure.
DavidSpickett wrote:
"...when running tests multiple times"?
Or in any situation?
https://github.com/llvm/llvm-project/pull/143797
___
@@ -204,19 +204,19 @@ def create_parser():
action="append",
help='Run "setting set SETTING VALUE" before executing any test.',
)
-group.add_argument(
-"-y",
-type=int,
-metavar="count",
-help="Specify the iteration count u
@@ -204,19 +204,19 @@ def create_parser():
action="append",
help='Run "setting set SETTING VALUE" before executing any test.',
)
-group.add_argument(
-"-y",
-type=int,
-metavar="count",
-help="Specify the iteration count u
@@ -665,17 +668,23 @@ def iter_filters():
filtered = True
print("adding filter spec %s to module %s" % (filterspec,
repr(module)))
tests = unittest.defaultTestLoader.loadTestsFromName(filterspec,
module)
-configuration.suite.addTests(tests)
+
DavidSpickett wrote:
When I need to do this I always end up on
https://stackoverflow.com/questions/12967232/repeatedly-run-a-shell-command-until-it-fails.
lit does not have a built in way to do this. I know libcxx has something that
will repeat failing tests, but not for running it N times reg
JDevlieghere wrote:
My (potentially controversial stance) is that instead of fixing this broken
functionality, we should remove it. When we switched over to using lit as the
test runner, the idea was that dotest would continue to be our test framework
but lit would be the driver, and that we c
ashgti wrote:
For reference, without this change if you use `-# 2` then you'll see an error
like:
```
Traceback (most recent call last):
File "/Users/harjohn/Projects/llvm-project/lldb/test/API/dotest.py", line 8,
in
lldbsuite.test.run_suite()
^^
File
"/Us
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/143797
This fixes the `dotest.py -# ` flag to work. Currently, if you try to use
the flag you'll get an error on the second run of the suite because python
unittest.TestSuite will remove the tests from the suite after
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This fixes the `dotest.py -# ` flag to work. Currently, if you try
to use the flag you'll get an error on the second run of the suite because
python unittest.TestSuite will remove the tests from the suit
13 matches
Mail list logo
