[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-04-25 Thread Pavel Labath via lldb-commits
labath wrote: I'm not sure what the deal, but I just noticed I don't see the "Manually Indexing DWARF" messages even though I'm certain that's what lldb is doing. It's possible they are being shadowed by another progress event or something... https://github.com/llvm/llvm-project/pull/121860 __

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: > if I start lldb with no arguments: https://github.com/llvm/llvm-project/issues/134064 > Does not happen if I have a program file, but this is also strange: This part appears to have been fixed. https://github.com/llvm/llvm-project/pull/121860 ___

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: @JDevlieghere if I start lldb with no arguments: ``` david.spickett@tcwg-jade-03-dev:~/build-llvm-aarch64$ ./bin/lldb << cursor is here at the start of the line, but no (lldb) was printed < the status bar> ``` Does not happen if I have a program file, but this is also strange

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-26 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Could you append to the PR description a list of known issues e.g. the redraw > on tab complete? > > It's discussed here in comments already but it's good to have a record of > what state we are at and what you have promised to address (not that I doubt > your sincerity

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-26 Thread David Spickett via lldb-commits
DavidSpickett wrote: > The tab complete issue is (should be?) fixed with the current state of this > PR. Cool! I did not check it again locally. If you're reasonably sure you've fixed it then I trust you there :) Go ahead and land this and I'll try my best to break it again at some point. h

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM Could you append to the PR description a list of known issues e.g. the redraw on tab complete? It's discussed here in comments already but it's good to have a record of what state we are at and what you have promised to address

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-26 Thread David Spickett via lldb-commits
@@ -0,0 +1,171 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-17 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @DavidSpickett does this LGTY? https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-14 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-13 Thread David Spickett via lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in { Global, DefaultStringValue<"${ansi.normal}">, Desc<"When displaying progress in a color-enabled terminal, use the ANSI terminal code specified in this format immediately after the progress message.">; + def Sh

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-12 Thread Jonas Devlieghere via lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in { Global, DefaultStringValue<"${ansi.normal}">, Desc<"When displaying progress in a color-enabled terminal, use the ANSI terminal code specified in this format immediately after the progress message.">; + def Sh

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,200 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From 13524447f9af1c8d1923e9ef8cc3693a1c53253a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH 1/2] [lldb] Implement a statusline in LLDB MIME-Version:

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From 13524447f9af1c8d1923e9ef8cc3693a1c53253a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement a statusline in LLDB MIME-Version: 1.0

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread David Spickett via lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in { Global, DefaultStringValue<"${ansi.normal}">, Desc<"When displaying progress in a color-enabled terminal, use the ANSI terminal code specified in this format immediately after the progress message.">; + def Sh

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread David Spickett via lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in { Global, DefaultStringValue<"${ansi.normal}">, Desc<"When displaying progress in a color-enabled terminal, use the ANSI terminal code specified in this format immediately after the progress message.">; + def Sh

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,200 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,200 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,42 @@ +//===-- StatuslineTest.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From 13524447f9af1c8d1923e9ef8cc3693a1c53253a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH 1/5] [lldb] Implement a statusline in LLDB MIME-Version:

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
@@ -1925,6 +1959,17 @@ void Debugger::CancelForwardEvents(const ListenerSP &listener_sp) { m_forward_listener_sp.reset(); } +bool Debugger::StatuslineSupported() { + if (GetShowStatusline()) { +if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) { + Fi

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in { Global, DefaultStringValue<"${ansi.normal}">, Desc<"When displaying progress in a color-enabled terminal, use the ANSI terminal code specified in this format immediately after the progress message.">; + def Sh

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thanks for taking the time to review and try this out, @DavidSpickett! > I will find this out looking at the code shortly, but - does this mean that > if you disable the statusline, you get the current progress reporting > implementation, or no progress reporting at all?

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
@@ -243,6 +243,19 @@ Status Debugger::SetPropertyValue(const ExecutionContext *exe_ctx, // Prompt colors changed. Ping the prompt so it can reset the ansi // terminal codes. SetPrompt(GetPrompt()); +} else if (property_path == + g_debugger_p

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: I was going to bikeshed (or indeed bike shed) "statusline" vs. "status line" but I see that NeoVim spells it this way. That's popular already, so one word is fine with me. Going to try this locally now. https://github.com/llvm/llvm-project/pull/1218

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -1925,6 +1959,17 @@ void Debugger::CancelForwardEvents(const ListenerSP &listener_sp) { m_forward_listener_sp.reset(); } +bool Debugger::StatuslineSupported() { + if (GetShowStatusline()) { +if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) { + Fi

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,171 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -1925,6 +1959,17 @@ void Debugger::CancelForwardEvents(const ListenerSP &listener_sp) { m_forward_listener_sp.reset(); } +bool Debugger::StatuslineSupported() { + if (GetShowStatusline()) { +if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) { + Fi

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: I had to try some Unicode of course. I think you have a TODO in there about this already but just because it was fun... ``` >>> "東".encode() b'\xe6\x9d\xb1' >>> "a".encode() b'a' ``` I can get way more 'a' before I get the '...' than '東'. Same for an emoji, which is a more

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -243,6 +243,19 @@ Status Debugger::SetPropertyValue(const ExecutionContext *exe_ctx, // Prompt colors changed. Ping the prompt so it can reset the ansi // terminal codes. SetPrompt(GetPrompt()); +} else if (property_path == + g_debugger_p

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: Some of this will be expected, but reporting it in case it's not. ``` $ ./bin/lldb /tmp/test.o (lldb) target create "/tmp/test.o" Current executable set to '/tmp/test.o' (aarch64). (lldb) << should this be here? test.o << is the status line ``` Is that empty line meant

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -1912,7 +1919,30 @@ bool FormatEntity::Format(const Entry &entry, Stream &s, return true; } return false; + + case Entry::Type::ProgressCount: +if (Target *target = Target::GetTargetFromContexts(exe_ctx, sc)) { + Debugger &debugger = target->GetDebugg

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,171 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,171 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,171 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,171 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -1925,6 +1959,17 @@ void Debugger::CancelForwardEvents(const ListenerSP &listener_sp) { m_forward_listener_sp.reset(); } +bool Debugger::StatuslineSupported() { + if (GetShowStatusline()) { +if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) { + Fi

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -1925,6 +1959,17 @@ void Debugger::CancelForwardEvents(const ListenerSP &listener_sp) { m_forward_listener_sp.reset(); } +bool Debugger::StatuslineSupported() { + if (GetShowStatusline()) { +if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) { + Fi

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,171 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -765,6 +765,8 @@ def setUpCommands(cls): # Disable fix-its by default so that incorrect expressions in tests don't # pass just because Clang thinks it has a fix-it. "settings set target.auto-apply-fixits false", +# Disable the

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in { Global, DefaultStringValue<"${ansi.normal}">, Desc<"When displaying progress in a color-enabled terminal, use the ANSI terminal code specified in this format immediately after the progress message.">; + def Sh

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: > displayed the bottom of the screen displayed **at** the bottom of the screen > The statusline supersedes the current progress reporting implementation. I will find this out looking at the code shortly, but - does this mean that if you disable the statusline, you get the

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-21 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Rebased on the recent debugger stream changes & improved the test based on code review feedback. https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From 13524447f9af1c8d1923e9ef8cc3693a1c53253a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement a statusline in LLDB MIME-Version: 1.0

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From e3df7eb885bc27464f6ba3cddd47147fa48f60f8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement a statusline in LLDB MIME-Version: 1.0

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-12 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,46 @@ +import lldb +import re + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test.lldbpexpect import PExpectTest + + +class TestStatusline(PExpectTest): +def do_setup(self): +# Create a target and run to a b

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-12 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,46 @@ +import lldb +import re + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test.lldbpexpect import PExpectTest + + +class TestStatusline(PExpectTest): +def do_setup(self): +# Create a target and run to a b

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-12 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,46 @@ +import lldb +import re + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test.lldbpexpect import PExpectTest + + +class TestStatusline(PExpectTest): +def do_setup(self): +# Create a target and run to a b

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-12 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,46 @@ +import lldb +import re + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test.lldbpexpect import PExpectTest + + +class TestStatusline(PExpectTest): +def do_setup(self): +# Create a target and run to a b

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From 19f5185ac5b19a656e0109d8aa011c49b36c5934 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH 1/4] [lldb] Implement a statusline in LLDB MIME-Version:

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-10 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Looks like > `lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py` > was deleted entirely. Was this intentional? Yes, because this replaces the old in-line progress printing. The statusline still trims messages that don't fit and progress isn

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From 19f5185ac5b19a656e0109d8aa011c49b36c5934 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH 1/3] [lldb] Implement a statusline in LLDB MIME-Version:

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From 19f5185ac5b19a656e0109d8aa011c49b36c5934 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH 1/2] [lldb] Implement a statusline in LLDB MIME-Version:

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 51759ffc4408e9eb5c2d40c9489ce3b98de233d5...19f5185ac5b19a656e0109d8aa011c49b36c5934 lldb/

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From 19f5185ac5b19a656e0109d8aa011c49b36c5934 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement a statusline in LLDB MIME-Version: 1.0

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Rebased & fixed the existing tests. https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-07 Thread Alex Langford via lldb-commits
bulbazord wrote: > Rebased & fixed the existing tests. Looks like `lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py` was deleted entirely. Was this intentional? https://github.com/llvm/llvm-project/pull/121860 ___ lld

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From ed0cf2866638162ff7314d31ee8325dc492060dd Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement a statusline in LLDB MIME-Version: 1.0

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Definitely needs some tests though (I thought you had some -- what happened > to those?) Yup, I'm planning on adding dedicated PExpect tests. The ones you remember are probably the ones from dependencies that have landed in separate PRs. https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-04 Thread Jonas Devlieghere via lldb-commits
@@ -73,6 +73,7 @@ #include "llvm/ADT/ArrayRef.h" #include "llvm/ADT/STLExtras.h" #include "llvm/ADT/StringRef.h" +#include "llvm/Support/Regex.h" JDevlieghere wrote: Remnant of trying to regex-away ANSI escape characters before I did #123430. https://github.

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-04 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,163 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-04 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I think this looks pretty good. The signal-safety of the code is very dubious (it was dubious even before that, but now it's even more), but I don't think that there's anything we can do about it from here. I think the only way we can have a real signal-saf

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-04 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,163 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-04 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-04 Thread Pavel Labath via lldb-commits
@@ -73,6 +73,7 @@ #include "llvm/ADT/ArrayRef.h" #include "llvm/ADT/STLExtras.h" #include "llvm/ADT/StringRef.h" +#include "llvm/Support/Regex.h" labath wrote: ? https://github.com/llvm/llvm-project/pull/121860 ___

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From b0cf540a08958ead1c7b9e38f30a2722fe780592 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH 1/3] [lldb] Implement a statusline in LLDB MIME-Version:

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,165 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From b0cf540a08958ead1c7b9e38f30a2722fe780592 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH 1/2] [lldb] Implement a statusline in LLDB MIME-Version:

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,165 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Alex Langford via lldb-commits
@@ -1198,13 +1207,13 @@ bool FormatEntity::Format(const Entry &entry, Stream &s, // FormatEntity::Entry::Definition encoding return false; case Entry::Type::EscapeCode: -if (exe_ctx) { - if (Target *target = exe_ctx->GetTargetPtr

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,165 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,60 @@ +//===-- Statusline.h -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From b0cf540a08958ead1c7b9e38f30a2722fe780592 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement a statusline in LLDB MIME-Version: 1.0

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From ecd2f911e597e02c0e3bb82384e701ada09e811e Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement a statusline in LLDB MIME-Version: 1.0

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,161 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From 9fd8d303ebc289e5b362e7252ae2f105a421a2e3 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement a statusline in LLDB MIME-Version: 1.0

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,161 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Pavel Labath via lldb-commits
@@ -1958,6 +1984,12 @@ lldb::thread_result_t Debugger::DefaultEventHandler() { // are now listening to all required events so no events get missed m_sync_broadcaster.BroadcastEvent(eBroadcastBitEventThreadIsListening); + if (!m_statusline && GetShowStatusline()) +m_st

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,58 @@ +//===-- Statusline.h -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Moving this out of Draft as I think I've addressed all the RFC feedback and I'd like to get some input on the code. I've broken out the changes that can stand on their own into separate PRs. The only outstanding blocker that I'm aware of is the use of an ansi escape code

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Add a statusline to command-line LLDB to display progress events and other information related to the current state of the debugger. The statusline is a dedicated area displayed the bottom of the scre

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere ready_for_review https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits