labath wrote:
lldb-dotest is a separate tool, which is usually only invoked manually when
debugging a specific test (and not invoked by `make check-lldb` like the bots
do). This fact that its args need to stay in sync is annoying an a relatively
common problem. I feel that there must be a way
zeroomega wrote:
Hi,
I noticed that our LLDB Windows builders all failed after this change is landed:
```
CMake Error at
C:/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/CMakeLists.txt:60 (message):
LLDB tests require 'make' tool. Please pass via `LLDB_TEST_MAKE` (or
otherwise disable te
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/111980
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I don't think so, it's used to generate dotest.py on all platforms I think.
Perhaps my cmake is being strict / less strict? The funny thing is, I can see
`LLDB_TEST_MAKE` set in the cache even when the build breaks.
https://github.com/llvm/llvm-project/pull/111980
https://github.com/weliveindetail approved this pull request.
Interesting! Your changes look fine, as they are symmetric with what we do here
for dsymutil. I just wonder why I didn't hit that. Is this a separate test
driver for Linux?
https://github.com/llvm/llvm-project/pull/111980
__
DavidSpickett wrote:
Putting this in review because I've zero idea why this fixes it. Without it I
get this on a rebuild:
```
Traceback (most recent call last):
File
"/home/david.spickett/llvm-project/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py",
line 67
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Fixes 0e913237871e8c9290e82be30be8b3484952eee0 /
https://github.com/llvm/llvm-project/pull/111531
For reasons I can't explain, a clean build works fine for me, and all the bots
are working fine. But
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/111980
Fixes 0e913237871e8c9290e82be30be8b3484952eee0 /
https://github.com/llvm/llvm-project/pull/111531
For reasons I can't explain, a clean build works fine for me, and all the bots
are working fine. But if I
