[Lldb-commits] [lldb] [lldb] Fix a format string in ClangASTSource (PR #107325)

2024-09-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/107325 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a format string in ClangASTSource (PR #107325)

2024-09-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Thanks! Is this asserting cause something changed in how llvm::formatv > validates the format string? Correct: https://github.com/llvm/llvm-project/pull/105745 https://github.com/llvm/llvm-project/pull/107325 ___ lldb-commits ma

[Lldb-commits] [lldb] [lldb] Fix a format string in ClangASTSource (PR #107325)

2024-09-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/107325 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a format string in ClangASTSource (PR #107325)

2024-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. Thanks! Is this asserting cause something changed in how llvm::formatv validates the format string? Or maybe I just never hit this codepath with expression log enabled before https://github.com/llvm/llvm-project/pull/107325

[Lldb-commits] [lldb] [lldb] Fix a format string in ClangASTSource (PR #107325)

2024-09-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes Without this, LLDB asserts when enabling the expression logs. --- Full diff: https://github.com/llvm/llvm-project/pull/107325.diff 1 Files Affected: - (modified) lldb/source/Plugins/ExpressionParser/Clan

[Lldb-commits] [lldb] [lldb] Fix a format string in ClangASTSource (PR #107325)

2024-09-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/107325 Without this, LLDB asserts when enabling the expression logs. >From 622c5b636d1a505f1ea3f68540db28061d8606ce Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Wed, 4 Sep 2024 16:02:20 -0700 Subject: [PATCH]