[Lldb-commits] [lldb] [lldb] Extract debug server location code (PR #145706)

2025-06-27 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/145706 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extract debug server location code (PR #145706)

2025-06-26 Thread Pavel Labath via lldb-commits
labath wrote: > Thanks, and sorry for not getting back to the Mac issue I said I'd debug, > I've been preoccupied lately. That's okay, no worries. > To make sure I understand, this change hoists the logic that discovers the > location of lldb-server (the function `GetDebugserverPath`) out of

[Lldb-commits] [lldb] [lldb] Extract debug server location code (PR #145706)

2025-06-26 Thread Yuval Deutscher via lldb-commits
https://github.com/yuvald-sweet-security edited https://github.com/llvm/llvm-project/pull/145706 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extract debug server location code (PR #145706)

2025-06-25 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/145706 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extract debug server location code (PR #145706)

2025-06-25 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/145706 .. from the guts of GDBRemoteCommunication to ~top level. This is motivated by #131519 and by the fact that's impossible to guess whether the author of a symlink intended it to be a "convenience shortcut" -- mea

[Lldb-commits] [lldb] [lldb] Extract debug server location code (PR #145706)

2025-06-25 Thread Pavel Labath via lldb-commits
labath wrote: @yuvald-sweet-security https://github.com/llvm/llvm-project/pull/145706 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extract debug server location code (PR #145706)

2025-06-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes .. from the guts of GDBRemoteCommunication to ~top level. This is motivated by #131519 and by the fact that's impossible to guess whether the author of a symlink intended it to be a "convenience shortcut" --