[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

carlocab wrote: Opened #120901 to fix the test failure. https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

slydiman wrote: Please fix the lldb-api::TestExprDiagnostics.py test ASAP. https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

slydiman wrote: The test `lldb-api::TestExprDiagnostics.py` is broken after this patch. https://lab.llvm.org/buildbot/#/builders/195/builds/2683 https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

adrian-prantl wrote: > LGTM. nit: I'd have called the API `SBError::GetStructuredError`. I have no strong feelings about this — I chose GetErrorData, because that's what `SBStructuredData SBCommandReturnObject::GetErrorData()` is called. https://github.com/llvm/llvm-project/pull/120784 ___

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/120784 >From 3113275ebe67a970ec01c380153fc6b9814ee939 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 20 Dec 2024 10:35:47 -0800 Subject: [PATCH] [lldb] Expose structured errors in SBError Building on to

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

https://github.com/JDevlieghere approved this pull request. LGTM module naming. https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

@@ -183,6 +186,9 @@ class Status { /// NULL otherwise. const char *AsCString(const char *default_error_str = "unknown error") const; + /// Get the error in machine-readable form. + StructuredData::ObjectSP GetErrorData() const; JDevlieghere wrote: W

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

medismailben wrote: LGTM. nit: I'd have called the API `SBError::GetStructuredError`. https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/120784 >From 59e2d804d49b549f0d3679caf72ed29493e8fd01 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 20 Dec 2024 10:35:47 -0800 Subject: [PATCH] [lldb] Expose structured errors in SBError Building on to

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 8c0090030bf89df7e0dbe5827a83d52627b2c87f...88f6c19a87e82f1cc0c589029d8eb288ec53eaba lldb/

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/120784 >From 88f6c19a87e82f1cc0c589029d8eb288ec53eaba Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 20 Dec 2024 10:35:47 -0800 Subject: [PATCH] [lldb] Expose structured errors in SBError Building on to

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes Building on top of previous work that exposed expression diagnostics via SBCommandReturnObject, this patch generalizes the support to expose any SBError as machine-readable structured data. One use-cas

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/120784 Building on top of previous work that exposed expression diagnostics via SBCommandReturnObject, this patch generalizes the support to expose any SBError as machine-readable structured data. One use-case o