[Lldb-commits] [lldb] [lldb] Clean up Socket headers for Android (PR #124453)

2025-01-27 Thread via lldb-commits
https://github.com/enh-google approved this pull request. https://github.com/llvm/llvm-project/pull/124453 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Clean up Socket headers for Android (PR #124453)

2025-01-27 Thread Pavel Labath via lldb-commits
labath wrote: > Some of that looks questionable and I question if most of the remaining > headers are actually necessary. I'd like to trim this down to only what is > necessary. This is probably the consequence of some refactoring (right now, most of the actual work is done in the individual

[Lldb-commits] [lldb] [lldb] Clean up Socket headers for Android (PR #124453)

2025-01-27 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Yeah, I have no idea what was that about. https://github.com/llvm/llvm-project/pull/124453 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb] Clean up Socket headers for Android (PR #124453)

2025-01-26 Thread Brad Smith via lldb-commits
brad0 wrote: ```arpa/inet.h``` and ```unistd.h``` are included under LLDB_ENABLE_POSIX just above. Some of that looks questionable and I question if most of the remaining headers are actually necessary. https://github.com/llvm/llvm-project/pull/124453 __

[Lldb-commits] [lldb] [lldb] Clean up Socket headers for Android (PR #124453)

2025-01-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Brad Smith (brad0) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/124453.diff 1 Files Affected: - (modified) lldb/source/Host/common/Socket.cpp (-10) ``diff diff --git a/lldb/source/Host/common/Socket.cpp b

[Lldb-commits] [lldb] [lldb] Clean up Socket headers for Android (PR #124453)

2025-01-25 Thread Brad Smith via lldb-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/124453 None >From 105b1dc748e2f4209dbda01e6b8b8ebc66af4b12 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sun, 26 Jan 2025 02:31:41 -0500 Subject: [PATCH] [lldb] Clean up Socket headers for Android --- lldb/source/Ho