https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138028
>From 4520d08763106b8d639e8afcb3f035a3070dee7f Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 13:37:15 -0700
Subject: [PATCH] [lldb][RPC] Upstream LLDB to RPC converstion Python sc
chelcassanova wrote:
I think this could be ready to land now @DavidSpickett and @JDevlieghere, could
you give this another once over?
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
@@ -0,0 +1,16 @@
+// Copy lldb-rpc-defines.h from source.
+# RUN: mkdir -p %t/input
+# RUN: mkdir -p %t/output
+# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input
chelcassanova wrote:
I changed all the tests so that the files are no longer copied fr
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138028
>From 2b6f460e1e2a358aafef80354010cbad87ac5134 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 13:37:15 -0700
Subject: [PATCH] [lldb][RPC] Upstream Python scripts
As part of upstre
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138028
>From 01e35b2635b3727be7f7ab6f2389086c6e86b776 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 13:37:15 -0700
Subject: [PATCH] [lldb][RPC] Upstream Python scripts
As part of upstre
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138028
>From 0b83514cde0b6fa2adc8c31a082a03770248ae4e Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 13:37:15 -0700
Subject: [PATCH] [lldb][RPC] Upstream Python scripts
As part of upstre
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138028
>From 31161db1c9b0bd040513eb8ff4504c29d1e6c04f Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 13:37:15 -0700
Subject: [PATCH] [lldb][RPC] Upstream Python scripts
As part of upstre
@@ -0,0 +1,20 @@
+// Copy lldb-defines.h from source.
+# RUN: mkdir -p %t/input
+# RUN: mkdir -p %t/output
+# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input
chelcassanova wrote:
Nice, I didn't know that about llvm-lit. I'll change everything to us
@@ -0,0 +1,20 @@
+// Copy lldb-defines.h from source.
+# RUN: mkdir -p %t/input
+# RUN: mkdir -p %t/output
+# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input
JDevlieghere wrote:
You're mixing two comment styles here, and lit doesn't actually treat
@@ -0,0 +1,16 @@
+// Copy lldb-rpc-defines.h from source.
+# RUN: mkdir -p %t/input
+# RUN: mkdir -p %t/output
+# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input
JDevlieghere wrote:
Is the goal to run this on the sources to catch regressions, or ar
@@ -0,0 +1,65 @@
+#!/usr/bin/env python3
+# Usage: convert-lldb-header-to-rpc-header.py
+# This scripts takes common LLDB headers (such as lldb-defines.h) and replaces
references to LLDB
+# with those for RPC. This happens for:
+# - namespace definitions
+# - namespace usage
+
https://github.com/chelcassanova reopened
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
@DavidSpickett I pushed here to address most of the outstanding changes I
needed to make from your comments, and this change should also fix the CI issue
on BuildKite. Could you give this patch another pass over?
https://github.com/llvm/llvm-project/pull/138028
___
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138028
>From a00c76df4467c85a7436fc340c79d0a15ab6231a Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 13:37:15 -0700
Subject: [PATCH] [lldb][RPC] Upstream Python scripts
As part of upstre
@@ -0,0 +1,13 @@
+// Generate a dummy SB API file using lldb-rpc-gen.
+# RUN: mkdir -p %t/server
+# RUN: mkdir -p %t/lib
chelcassanova wrote:
I just checked on macOS and got the same error. The error is a bit misleading,
it's actually happening because I'm using
@@ -0,0 +1,18 @@
+// Copy lldb-rpc-defines.h from source.
+# RUN: mkdir -p %t/input
+# RUN: mkdir -p %t/output
+# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input
+
+// Run the convert script on it, then run the framework include fix on it. The
framework version fix
@@ -0,0 +1,13 @@
+// Generate a dummy SB API file using lldb-rpc-gen.
+# RUN: mkdir -p %t/server
+# RUN: mkdir -p %t/lib
chelcassanova wrote:
> I don't see anything that would need job control, I'm wondering if a stray
> character is causing the shell to think t
@@ -0,0 +1,65 @@
+#!/usr/bin/env python3
+# Usage: convert-lldb-header-to-rpc-header.py
+# This scripts takes common LLDB headers (such as lldb-defines.h) and replaces
references to LLDB
+# with those for RPC. This happens for:
+# - namespace definitions
+# - namespace usage
+
@@ -0,0 +1,65 @@
+#!/usr/bin/env python3
+# Usage: convert-lldb-header-to-rpc-header.py
+# This scripts takes common LLDB headers (such as lldb-defines.h) and replaces
references to LLDB
+# with those for RPC. This happens for:
+# - namespace definitions
+# - namespace usage
+
chelcassanova wrote:
For what it's worth, while these scripts do work for intended purpose for now,
an approach I'd love is to have all this header modification be a subtool of
the `lldb-rpc-gen` tool itself. Subtooling a ClangTool is something I'm not too
sure on how to do so maybe a better C
@@ -0,0 +1,18 @@
+// Copy lldb-rpc-defines.h from source.
+# RUN: mkdir -p %t/input
+# RUN: mkdir -p %t/output
+# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input
+
+// Run the convert script on it, then run the framework include fix on it. The
framework version fix
@@ -0,0 +1,65 @@
+#!/usr/bin/env python3
+# Usage: framework-header-version-fix.py
MAJOR MINOR PATCH
+# This script modifies lldb-rpc-defines.h to uncomment the macro defines used
for the LLDB
+# major, minor and patch values as well as populating their definitions.
+
+import
@@ -0,0 +1,44 @@
+#!/usr/bin/env python3
+# Usage: framework-header-include-fix.py
+# This script modifies all #include lines in all lldb-rpc headers
+# from either filesystem or local includes to liblldbrpc includes.
+
+import argparse
+import os
+import re
+
+
+def main():
+
@@ -0,0 +1,65 @@
+#!/usr/bin/env python3
+# Usage: convert-lldb-header-to-rpc-header.py
+# This scripts takes common LLDB headers (such as lldb-defines.h) and replaces
references to LLDB
+# with those for RPC. This happens for:
+# - namespace definitions
+# - namespace usage
+
@@ -0,0 +1,13 @@
+// Generate a dummy SB API file using lldb-rpc-gen.
+# RUN: mkdir -p %t/server
+# RUN: mkdir -p %t/lib
DavidSpickett wrote:
CI failing with:
```
/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-spx4x-1/llvm-project/github-pull-requests/build/t
https://github.com/bulbazord approved this pull request.
Thanks for adding tests. Please let others take a look before merging.
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138028
>From c51a312cd3901a1e51d9e210b3efdc89389f0e10 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 13:37:15 -0700
Subject: [PATCH] [lldb][RPC] Upstream Python scripts
As part of upstre
chelcassanova wrote:
I can add shell tests 👍🏾
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
We should add shell tests for these scripts.
https://github.com/llvm/llvm-project/pull/138028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
As part of upstreaming LLDB RPC, this commit adds python scripts that are used
by LLDB RPC to modify the public lldb header files for use with RPC.
https://discourse.llvm.org/t/rfc-upstreaming-lldb
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/138028
As part of upstreaming LLDB RPC, this commit adds python scripts that are used
by LLDB RPC to modify the public lldb header files for use with RPC.
https://discourse.llvm.org/t/rfc-upstreaming-lldb-rpc/85
32 matches
Mail list logo
