https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/114303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/114303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/114303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rnk approved this pull request.
https://github.com/llvm/llvm-project/pull/114303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1810,7 +1813,27 @@
SymbolFileNativePDB::ParseVariablesForCompileUnit(CompileUnit &comp_unit,
VariableList &variables) {
PdbSymUid sym_uid(comp_unit.GetID());
lldbassert(sym_uid.kind() == PdbSymUidKind::Compiland);
- re
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/114303
>From 215c36a380946a0c8cab63605bd0a9da13e642cd Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Tue, 29 Oct 2024 13:19:50 -0700
Subject: [PATCH 1/3] [lldb][NativePDB] Parse global variables.
---
.../NativePDB/S
@@ -265,6 +265,7 @@ class SymbolFileNativePDB : public SymbolFileCommon {
// UID for anonymous union and anonymous struct as they don't have entities
in
// pdb debug info.
lldb::user_id_t anonymous_id = LLDB_INVALID_UID - 1;
+ std::optional m_cu_count = 0;
-
@@ -1810,7 +1813,27 @@
SymbolFileNativePDB::ParseVariablesForCompileUnit(CompileUnit &comp_unit,
VariableList &variables) {
PdbSymUid sym_uid(comp_unit.GetID());
lldbassert(sym_uid.kind() == PdbSymUidKind::Compiland);
- re
@@ -888,7 +888,8 @@ VariableSP
SymbolFileNativePDB::CreateGlobalVariable(PdbGlobalSymId var_id) {
CompUnitSP comp_unit;
std::optional modi = m_index->GetModuleIndexForVa(addr);
- if (!modi) {
+ // Some globals has modi points to the linker module, ignore them.
+ if (!m
@@ -1810,7 +1813,27 @@
SymbolFileNativePDB::ParseVariablesForCompileUnit(CompileUnit &comp_unit,
VariableList &variables) {
PdbSymUid sym_uid(comp_unit.GetID());
lldbassert(sym_uid.kind() == PdbSymUidKind::Compiland);
- re
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/114303
>From 215c36a380946a0c8cab63605bd0a9da13e642cd Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Tue, 29 Oct 2024 13:19:50 -0700
Subject: [PATCH 1/2] [lldb][NativePDB] Parse global variables.
---
.../NativePDB/S
@@ -365,18 +365,20 @@ void SymbolFileNativePDB::InitializeObject() {
}
uint32_t SymbolFileNativePDB::CalculateNumCompileUnits() {
+ if (m_cu_count)
+return *m_cu_count;
labath wrote:
`CalculateNumCompileUnits` is wrapped by `GetNumCompileUnits`, which ma
@@ -1810,7 +1813,27 @@
SymbolFileNativePDB::ParseVariablesForCompileUnit(CompileUnit &comp_unit,
VariableList &variables) {
PdbSymUid sym_uid(comp_unit.GetID());
lldbassert(sym_uid.kind() == PdbSymUidKind::Compiland);
- re
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/114303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
This doesn't parse S_CONSTANT case yet, because I found that
`std::strong_ordering::equal` being a S_CONSTANT and has type of LF_STRUCTURE
which is not currently handled when creating dwarf expression for the v
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/114303
This doesn't parse S_CONSTANT case yet, because I found that
`std::strong_ordering::equal` being a S_CONSTANT and has type of LF_STRUCTURE
which is not currently handled when creating dwarf expression for the
16 matches
Mail list logo
