[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/141063 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/141063 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

@@ -93,13 +93,6 @@ function(add_lldb_library name) set(libkind STATIC) endif() - #PIC not needed on Win - # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options DavidSpickett wrote: Sounds reasonable, I've been bitten by distro c

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

@@ -93,13 +93,6 @@ function(add_lldb_library name) set(libkind STATIC) endif() - #PIC not needed on Win - # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options labath wrote: I believe we don't -- and I think that's the right thi

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/141063 Like the comment says, this really is a no-op and has no offect on the generated build commants. >From 5eac5e7976005c74d5e1d669a64596688b3d8d25 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 22 May 2025

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

@@ -93,13 +93,6 @@ function(add_lldb_library name) set(libkind STATIC) endif() - #PIC not needed on Win - # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options DavidSpickett wrote: Do we in fact use target_compile_options? Or do

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/141063 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/141063 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Like the comment says, this really is a no-op and has no offect on the generated build commants. --- Full diff: https://github.com/llvm/llvm-project/pull/141063.diff 1 Files Affected: - (modified) lldb/cmak