[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > We agreed that the native parser would be the way forward in the last > EuroLLVM round-table IIRC (CC @JDevlieghere @labath). That's right. The problem is that neither implementation is complete, and things only work because there's an automatic fallback. No matter which

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: https://github.com/llvm/llvm-project/issues/114906 as well. https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread Michael Buch via lldb-commits
Michael137 wrote: I think as a pre-requisite to this we should remove the non-native PDB parser (and anything associated with it). That way we wouldn't need any special environment variable setting etc. We agreed that the native parser would be the way forward in the last EuroLLVM round-table

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes >From https://github.com/llvm/llvm-project/pull/148554#issuecomment-3083261858 >- this adds an option for API tests to be run with the native PDB reader on >Windows. As there are a lot of failures with PDB, this is

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz ready_for_review https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149305 >From 457d51e195fd2414424809efd88592884e13272d Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Thu, 17 Jul 2025 15:10:24 +0200 Subject: [PATCH] [LLDB] Run API tests with native PDB too --- .../Python/lldbsuite/te

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread via lldb-commits
Nerixyz wrote: I made it opt-in now. A test can set `TEST_WITH_PDB_DEBUG_INFO = True`. Unfortunately, all STL tests currently fail. Most of this is because the demangled name in the native PDB parser has spaces at different positions than the DIA parser which I used before. I'm not sure if it

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149305 >From 0c9292538507307467cdf8184c5599dbadb79bb9 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Thu, 17 Jul 2025 15:10:24 +0200 Subject: [PATCH] [LLDB] Run API tests with native PDB too --- .../Python/lldbsuite/te

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: Opened https://github.com/llvm/llvm-project/issues/149498 so you can refer to it. I think it's a reasonable pitch to say: * Formatters that work with PDB are a good idea. * If we opt-in those formatters for testing using PDB, they will be run on at least Linaro's Windows o

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: I ran this on Linaro's bot machine and got these results: ``` Unresolved Tests (5): lldb-api :: functionalities/data-formatter/data-formatter-stl/generic/string/TestDataFormatterStdString.py lldb-api :: lang/c/vla/TestVLA.py lldb-api :: python_api/

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: Yes this is what I was thinking of. Don't go diving into the failures yet, I'll try this on the bot machine first and see if we need other adjustments. https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-17 Thread via lldb-commits
Nerixyz wrote: @DavidSpickett added the PDB tests here - Is the general approach fine? https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-17 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149305 >From eeea8f973f5583276e4b9c24e8cddfa67b0cf06f Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Thu, 17 Jul 2025 15:10:24 +0200 Subject: [PATCH] [LLDB] Run API tests with native PDB too --- .../Python/lldbsuite/te

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/builders/builder.py lldb/packages/Pytho

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-17 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-17 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/149305 >From https://github.com/llvm/llvm-project/pull/148554#issuecomment-3083261858 >- this runs the API tests with the native PDB on Windows. Using native over >DIA because it's easier to inspect/debug. One of the