[Lldb-commits] [lldb] [LLDB] Reappply SBSaveCore AddMemoryList (PR #107159)

2024-09-06 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/107159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Reappply SBSaveCore AddMemoryList (PR #107159)

2024-09-04 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: Hey @bulbazord, this was reverted because it failed `TestSkinnyCorefile.py` [Link](https://github.com/llvm/llvm-project/blob/main/lldb/test/API/macosx/skinny-corefile/TestSkinnyCorefile.py#L15), I'm running into issues where it keeps coming up as unsupported. Is there a way to t

[Lldb-commits] [lldb] [LLDB] Reappply SBSaveCore AddMemoryList (PR #107159)

2024-09-03 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/107159 >From 63a343d2613d09a866180c8bebdf4568e20fd3b7 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 29 Aug 2024 10:09:19 -0700 Subject: [PATCH 1/3] =?UTF-8?q?Reapply=20"[LLDB][SBSaveCore]=20Add=20selec?= =?U

[Lldb-commits] [lldb] [LLDB] Reappply SBSaveCore AddMemoryList (PR #107159)

2024-09-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 18cf14efe3e82b2343817fd174bcac48244c8f50 e79e6561b68ff11f93239ce901de1e02aa0c16c3 --e

[Lldb-commits] [lldb] [LLDB] Reappply SBSaveCore AddMemoryList (PR #107159)

2024-09-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Reapplies #106293, testing identified issue in the merging code. I used this opportunity to strip CoreFileMemoryRanges to it's own file and then add unit tests on it's behavior. --- Patch is 41.75 KiB, tru

[Lldb-commits] [lldb] [LLDB] Reappply SBSaveCore AddMemoryList (PR #107159)

2024-09-03 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: Need to verify this passes `SaveSkinnyCore`. https://github.com/llvm/llvm-project/pull/107159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Reappply SBSaveCore AddMemoryList (PR #107159)

2024-09-03 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/107159 Reapplies #106293, testing identified issue in the merging code. I used this opportunity to strip CoreFileMemoryRanges to it's own file and then add unit tests on it's behavior. >From 63a343d2613d09a866180c8be