labath wrote:
> Are these actually different on Mac? These 4 are the same on BSD to my
> knowledge.
I haven't checked, I guess these four might be the same on a mac, but that
definitely is not the case everywhere. We're currently growing AIX support, and
that one seems to have different numbe
Jlalond wrote:
https://lab.llvm.org/buildbot/#/builders/197/builds/6014 looks like we're
passing
https://github.com/llvm/llvm-project/pull/141971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/141971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@labath I'm landing to not leave the build broken, but if you have a better
solution/means of doing this let me know and I'll implement it
https://github.com/llvm/llvm-project/pull/141971
___
lldb-commits mailing list
lldb-commits@lists
Jlalond wrote:
> Ummm... I should have caught this before, but this isn't correct because the
> host system may (and some do) use different signal numbers for these
> constants.
Are these actually different on Mac? These 4 are the same on BSD to my
knowledge.
How do you think we should go ab
@@ -34,6 +34,20 @@
#define MAP_PRIVATE 2
#define MAP_ANON 0x20
+// For other platforms that use platform linux
+#ifndef SIGILL
+#define SIGILL 4
+#endif
+#ifndef SIGBUS
+#define SIGBUS 7
+#endif
+#ifndef SIGFPE
+#define SIGFPE 8
+#endif
+#ifndef SIGSEGV
+#define SIGSEGV 11
---
labath wrote:
Ummm... I should have caught this before, but this isn't correct because the
host system may (and some do) use different signal numbers for these constants.
So, on windows, you get an undefined symbol error, but on e.g. macos, you'd
just get a wrong value. You should take these
Jlalond wrote:
I'm going to wait to see how many build issues we get before landing.
https://github.com/llvm/llvm-project/pull/141971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -34,6 +34,20 @@
#define MAP_PRIVATE 2
#define MAP_ANON 0x20
+// For other platforms that use platform linux
+#ifndef SIGILL
+#define SIGILL 4
+#endif
+#ifndef SIGBUS
+#define SIGBUS 7
+#endif
+#ifndef SIGFPE
+#define SIGFPE 8
+#endif
+#ifndef SIGSEGV
+#define SIGSEGV 11
---
https://github.com/dmpots edited
https://github.com/llvm/llvm-project/pull/141971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -34,6 +34,20 @@
#define MAP_PRIVATE 2
#define MAP_ANON 0x20
+// For other platforms that use platform linux
dmpots wrote:
Are these guaranteed to be defines and not constants?
https://github.com/llvm/llvm-project/pull/141971
_
https://github.com/dmpots approved this pull request.
Approving to unblock windows build break.
https://github.com/llvm/llvm-project/pull/141971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/141971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Another iteration of fixes for #141670. Platform linux can be used by
other platforms, so we need to supply the signal values if they're not defined.
---
Full diff: https://github.com/llvm/llvm-project/pull/
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/141971
Another iteration of fixes for #141670. Platform linux can be used by other
platforms, so we need to supply the signal values if they're not defined.
>From 0612b888a0dd0cda09fbaa89f5e68c15a1bc9e98 Mon Sep 17 00
15 matches
Mail list logo
