[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/128966 >From 7597ee080abcaaa8b88af316409feb849fb6d7f2 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 26 Feb 2025 15:38:24 -0800 Subject: [PATCH 1/4] Add a finalize method to the sbprogress, with an associated

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-27 Thread Jonas Devlieghere via lldb-commits
@@ -12,3 +12,10 @@ and will always send an initial progress update, updates when Progress::Increment() is called, and also will make sure that a progress completed update is reported even if the user doesn't explicitly cause one to be sent.") lldb::SBProgress; + +%feature("docs

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/128966 >From 7597ee080abcaaa8b88af316409feb849fb6d7f2 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 26 Feb 2025 15:38:24 -0800 Subject: [PATCH 1/3] Add a finalize method to the sbprogress, with an associated

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/128966 >From 7597ee080abcaaa8b88af316409feb849fb6d7f2 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 26 Feb 2025 15:38:24 -0800 Subject: [PATCH 1/3] Add a finalize method to the sbprogress, with an associated

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-27 Thread Jacob Lalonde via lldb-commits
@@ -12,3 +12,10 @@ and will always send an initial progress update, updates when Progress::Increment() is called, and also will make sure that a progress completed update is reported even if the user doesn't explicitly cause one to be sent.") lldb::SBProgress;

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/128966 >From 7597ee080abcaaa8b88af316409feb849fb6d7f2 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 26 Feb 2025 15:38:24 -0800 Subject: [PATCH 1/2] Add a finalize method to the sbprogress, with an associated

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-26 Thread Greg Clayton via lldb-commits
@@ -40,7 +40,17 @@ SBProgress::~SBProgress() = default; void SBProgress::Increment(uint64_t amount, const char *description) { LLDB_INSTRUMENT_VA(amount, description); + if (!m_opaque_up) +return; + m_opaque_up->Increment(amount, description); } +void SBProgress::

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-26 Thread Jacob Lalonde via lldb-commits
@@ -12,3 +12,10 @@ and will always send an initial progress update, updates when Progress::Increment() is called, and also will make sure that a progress completed update is reported even if the user doesn't explicitly cause one to be sent.") lldb::SBProgress;

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-26 Thread Jacob Lalonde via lldb-commits
@@ -33,3 +33,17 @@ def test_without_external_bit_set(self): expected_string = "Test progress first increment" progress.Increment(1, expected_string) self.assertFalse(listener.PeekAtNextEvent(event)) + +def test_progress_finalize(self): +"""Te

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-26 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/128966 >From 3c4b333869c17005deb8d4e9307babc94d0dc9b5 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 26 Feb 2025 15:38:24 -0800 Subject: [PATCH 1/3] Add a finalize method to the sbprogress, with an associated

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-26 Thread Greg Clayton via lldb-commits
@@ -12,3 +12,10 @@ and will always send an initial progress update, updates when Progress::Increment() is called, and also will make sure that a progress completed update is reported even if the user doesn't explicitly cause one to be sent.") lldb::SBProgress;

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-26 Thread Greg Clayton via lldb-commits
@@ -59,6 +59,11 @@ class LLDB_API SBProgress { void Increment(uint64_t amount, const char *description = nullptr); + /// Explicitly finalize an SBProgress, this can be used to terminate a + /// progress on command instead of waiting for a garbage collection or other + //

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-26 Thread Greg Clayton via lldb-commits
@@ -33,3 +33,17 @@ def test_without_external_bit_set(self): expected_string = "Test progress first increment" progress.Increment(1, expected_string) self.assertFalse(listener.PeekAtNextEvent(event)) + +def test_progress_finalize(self): --

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-26 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/128966 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-26 Thread Greg Clayton via lldb-commits
@@ -33,3 +33,17 @@ def test_without_external_bit_set(self): expected_string = "Test progress first increment" progress.Increment(1, expected_string) self.assertFalse(listener.PeekAtNextEvent(event)) + +def test_progress_finalize(self): +"""Te

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-26 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/128966 >From 3c4b333869c17005deb8d4e9307babc94d0dc9b5 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 26 Feb 2025 15:38:24 -0800 Subject: [PATCH 1/2] Add a finalize method to the sbprogress, with an associated

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-26 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/128966 >From 3c4b333869c17005deb8d4e9307babc94d0dc9b5 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 26 Feb 2025 15:38:24 -0800 Subject: [PATCH 1/2] Add a finalize method to the sbprogress, with an associated

[Lldb-commits] [lldb] [LLDB][SBProgress] Add a finalize method (PR #128966)

2025-02-26 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/128966 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits