Re: [Lldb-commits] [PATCH] Use the DWARF linkage name when importing C++ methods

2017-11-20 Thread Nelson Elhage via lldb-commits
Thanks, created here: https://reviews.llvm.org/D40283 I got here via http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch ; Should that documentation be updated? Would a patch be appropriate? - Nelson On Mon, Nov 20, 2017 at 7:57 AM Greg Clayton wrote: > Please submit a revi

Re: [Lldb-commits] [PATCH] Use the DWARF linkage name when importing C++ methods

2017-11-20 Thread Greg Clayton via lldb-commits
Please submit a review of this patch through reviews.llvm.org . - svn diff -x -U9 > /tmp/a.patch - login or create a login if you don't already have one - Select Differential from the top left corner - Click "+ Create Diff" in upper right - Click "Choose File" and s

[Lldb-commits] [PATCH] Use the DWARF linkage name when importing C++ methods

2017-11-19 Thread Nelson Elhage via lldb-commits
When importing C++ methods into clang AST nodes from the DWARF symbol table, preserve the DW_AT_linkage_name and use it as the linker ("asm") name for the symbol. Concretely, this enables `expression` to call into names that use the GNU `abi_tag` extension, and enables lldb to call into code using