This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbbb419151cc8: [lldb] Add IsFullyInitialized to DynamicLoader
(authored by JDevlieghere).
Herald added a project: LLDB.
Changed prior to commit:
ht
aprantl added inline comments.
Comment at: lldb/include/lldb/Target/DynamicLoader.h:260
+ /// safe to call certain APIs or SPIs.
+ virtual bool IsSafeToCallAPI() { return true; }
+
*Perhaps* IsFullyInitialized() ?
CHANGES SINCE LAST ACTION
https://reviews.l
JDevlieghere added inline comments.
Comment at:
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp:1118
+bool DynamicLoaderMacOSXDYLD::IsSafeToCallAPI() {
+ if (ReadAllImageInfosStructure())
+return m_dyld_all_image_infos.libSystemInitialized;
---
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at:
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp:1118
+bool DynamicLoaderMacOSXDYLD::IsSafeToCallAPI() {
+ if (ReadAllImageInfosS
JDevlieghere created this revision.
JDevlieghere added reviewers: friss, aprantl, jingham.
JDevlieghere requested review of this revision.
On Darwin based systems, lldb will get notified by dyld before it itself
finished initializing, at which point it's not safe to call certain APIs or
SPIs. Ad
