This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1b7e5d461aee: [lldb] Fix error message in IRInterpreter
(authored by werat).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
werat added a comment.
I was looking into the issue with `SBValue::Persist`
(https://discord.com/channels/636084430946959380/636732809708306432/817370459284832297)
and the logs and errors eventually led me here to `IRInterpreter`. And the
incorrect error message I noticed just by accident :)
teemperor added a comment.
I would be curious how you found that bug? I believe a lot of these errors are
kinda impossible to reach in a normal test setup (I remember I tried writing
some tests for this but can't remember finding a good way to get into all the
different error branches in IRInte
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: JDevlieghere.
LGTM.
I think the Read/Write methods should return a Status instead of some out
parameter, but that seems like a NFC follow-up refactoring (I can
werat created this revision.
werat added reviewers: teemperor, spyffe.
werat requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
`memory_read_error` -> `memory_write_error`
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D9817
