[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG389955c69a3b: [lldb] add check for libcxx runtime (authored by rmaz, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97227/new/ https:/

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97227/new/ https://reviews.llvm.org/D97227 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

rmaz updated this revision to Diff 325600. rmaz added a comment. update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97227/new/ https://reviews.llvm.org/D97227 Files: lldb/test/CMakeLists.txt Index: lldb/test/CMakeLists.txt ==

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

JDevlieghere added inline comments. Comment at: lldb/test/CMakeLists.txt:121 "LLDB test suite requires libc++, but it is currently disabled. " "Please add `libcxx` to `LLVM_ENABLE_PROJECTS` or disable tests " "via `LLDB_INCLUDE_TESTS=OFF`.")

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97227/new/ https://reviews.llvm.org/D97227 ___

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

rmaz added a comment. In D97227#2580049 , @smeenai wrote: > My understanding of the issue is that, with the runtimes build, the `cxx` > target will get created after we process LLDB's build files. The `TARGET cxx` > check here will therefore fail, but th

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

smeenai added a comment. My understanding of the issue is that, with the runtimes build, the `cxx` target will get created after we process LLDB's build files. The `TARGET cxx` check here will therefore fail, but the `cxx` target will end up existing later, and CMake is perfectly fine adding a

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

rmaz created this revision. Herald added a subscriber: mgorny. rmaz requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When enabling LLDB tests with `LLVM_ENABLE_RUNTIMES=libcxx` CMake will fail with: LLDB test suite requires libc++, but i