This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb0186c25c62e: [lldb] Refine ThreadPlan::ShouldAutoContinue
(authored by kastiglione).
Changed prior to commit:
https://reviews.llvm.org/D97076?vs=
jingham added inline comments.
Comment at: lldb/include/lldb/Target/ThreadPlan.h:354-359
+ /// Returns whether this thread plan overrides the `ShouldStop` of previous
+ /// plans.
+ ///
+ /// When processing the thread plan stack, this function gives plans the
+ /// ability
kastiglione added a comment.
Good call on calling ShouldAutoContinue before Pop.
Comment at: lldb/include/lldb/Target/ThreadPlan.h:354-359
+ /// Returns whether this thread plan overrides the `ShouldStop` of previous
+ /// plans.
+ ///
+ /// When processing the thread plan
jingham added a comment.
This seems like a fine improvement. One little nit, I would ask the current
plan ShouldAutoContinue before popping it. Popping the plan does call WillPop,
so the plan does have a chance to react to being popped, and you don't know
what it will do. So to be on the saf
kastiglione added inline comments.
Comment at: lldb/include/lldb/Target/ThreadPlan.h:354-359
+ /// Returns whether this thread plan overrides the `ShouldStop` of previous
+ /// plans.
+ ///
+ /// When processing the thread plan stack, this function gives plans the
+ /// abil
kastiglione created this revision.
kastiglione added reviewers: jingham, aprantl.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Adjust `ShouldAutoContinue` to be available to any thread plan previous to the
plan that
explains
