Re: [Lldb-commits] [PATCH] D9703: Adds support for ARM hardware watchpoints

2015-08-25 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good with a few minor comments inline Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp:397 @@ +396,3 @@ + +uint32_t control_valu

Re: [Lldb-commits] [PATCH] D9703: Adds support for ARM hardware watchpoints

2015-08-25 Thread Muhammad Omair Javaid via lldb-commits
omjavaid updated this revision to Diff 33075. omjavaid added a comment. This updated patches correct problems in arm hardware watchpoint support patch posted earlier. This patch has been tested on samsung chromebook (ARM - Linux) and PandaBoard using basic watchpoint test application. Also it