[Lldb-commits] [PATCH] D96555: [lldb] Remove the legacy FreeBSD plugin

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D96555#2558465 , @mgorny wrote: > @labath, any clue if I'm missing some no-longer-necessary code? I feel like I > was supposed to also remove someth

[Lldb-commits] [PATCH] D96555: [lldb] Remove the legacy FreeBSD plugin

emaste added inline comments. Comment at: lldb/tools/lldb-server/CMakeLists.txt:13 if(CMAKE_SYSTEM_NAME MATCHES "FreeBSD") - list(APPEND LLDB_PLUGINS -lldbPluginProcessFreeBSDRemote -lldbPluginProcessFreeBSD) + list(APPEND LLDB_PLUGINS lldbPluginProcessFreeBSDRemote)

[Lldb-commits] [PATCH] D96555: [lldb] Remove the legacy FreeBSD plugin

emaste added a comment. Not sure if you're missing something, but removing the old plugin LGTM Comment at: lldb/tools/lldb-server/CMakeLists.txt:13 if(CMAKE_SYSTEM_NAME MATCHES "FreeBSD") - list(APPEND LLDB_PLUGINS -lldbPluginProcessFreeBSDRemote -lldbPluginProcessFre

[Lldb-commits] [PATCH] D96555: [lldb] Remove the legacy FreeBSD plugin

mgorny added a comment. @labath, any clue if I'm missing some no-longer-necessary code? I feel like I was supposed to also remove something responsible for launching/attaching processes in the old mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96555/new/ https://reviews.llvm.org/