This revision was automatically updated to reflect the committed changes.
Closed by commit rG188b0747c166: Support dereferencing a DWARF scalar stack
value (authored by aprantl).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D96549?vs=323489&id=323496#toc
Repo
aprantl added inline comments.
Comment at: lldb/unittests/Expression/DWARFExpressionTest.cpp:347
+ ExecutionContext exe_ctx(process_sp);
+ EXPECT_THAT_EXPECTED(Evaluate({DW_OP_lit4, DW_OP_deref}, {}, {}, &exe_ctx),
+ llvm::HasValue(GetScalar(32, 0x07060504
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm.
Comment at: lldb/unittests/Expression/DWARFExpressionTest.cpp:347
+ ExecutionContext exe_ctx(process_sp);
+ EXPECT_THAT_EXPECTED(Evaluate({DW_OP_lit4, DW_OP_deref},
aprantl updated this revision to Diff 323489.
aprantl added a comment.
There's actually no reason to fill a second memory buffer. Replaced all of
DoReadMemory with a single for loop.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96549/new/
https://reviews.llvm.org/D96549
Files:
lldb
aprantl updated this revision to Diff 323488.
aprantl added a comment.
Herald added a subscriber: mgorny.
That took me a little to get right, but here you go! Mock process.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96549/new/
https://reviews.llvm.org/D96549
Files:
lldb/source/Exp
JDevlieghere added a comment.
I think this makes sense. From a DWARF perspective this is sound, all the
standard says is that the popped value must have an integral type.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96549/new/
https://reviews.llvm.org/D96549
_
vsk added a comment.
The logic change seems reasonable to me. Any chance we can provide a mock
memory in the DwarfExpression unit test, or check in assembly for a program
that uses such an entry value expression?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96549/new/
https://reviews
aprantl created this revision.
aprantl added reviewers: vsk, JDevlieghere, jasonmolenda.
Herald added a subscriber: lxfind.
aprantl requested review of this revision.
Swift async functions receive function arguments inside a heap-allocated data
structure, similar to how ObjC block captures or C++
