This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG606c3be85d92: [lldb] Minor cleanups to ThreadPlan.h (NFC)
(authore
kastiglione updated this revision to Diff 322779.
kastiglione added a comment.
- Make CachePlanExplainsStop private
- Delete unused GetCachedPlanExplainsStop
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96277/new/
https://reviews.llvm.org/D96277
kastiglione updated this revision to Diff 322773.
kastiglione added a comment.
Restore and call CachePlanExplainsStop
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96277/new/
https://reviews.llvm.org/D96277
Files:
lldb/include/lldb/Target/Thread
jingham added a comment.
This is okay. It seems like CachePlanExplainsStop wasn't used because it's
done by hand instead. A better patch might be to stop doing that and use the
function instead? But the argument's not terribly compelling either way...
Repository:
rG LLVM Github Monorepo
kastiglione created this revision.
kastiglione added a reviewer: jingham.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
While learning about ThreadPlan, I did a bit of cleanup:
- Remove unused code
- Move functions to protect
